From 45f3365d06bbb43d00e9a08dc2c525e4f7dbc2b7 Mon Sep 17 00:00:00 2001 From: Chris Smowton Date: Fri, 5 Mar 2021 12:52:38 +0000 Subject: [PATCH] Apply suggestions from code review Note value-preserving functions can't be constructors Co-authored-by: Anders Schack-Mulligen --- java/ql/src/semmle/code/java/dataflow/FlowSteps.qll | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/java/ql/src/semmle/code/java/dataflow/FlowSteps.qll b/java/ql/src/semmle/code/java/dataflow/FlowSteps.qll index dcb3e8b1727..db3029cc21c 100644 --- a/java/ql/src/semmle/code/java/dataflow/FlowSteps.qll +++ b/java/ql/src/semmle/code/java/dataflow/FlowSteps.qll @@ -21,7 +21,7 @@ private module Frameworks { } /** - * A method or constructor that returns the exact value of one of its parameters or the qualifier. + * A method that returns the exact value of one of its parameters or the qualifier. * * Extend this class and override `returnsValue` to add additional value-preserving steps through a * method that should be added to the basic local flow step relation. @@ -29,16 +29,16 @@ private module Frameworks { * These steps will be visible for all global data-flow purposes, as well as via * `DataFlow::Node.getASuccessor` and other related functions exposing intraprocedural dataflow. */ -abstract class ValuePreservingCallable extends Callable { +abstract class ValuePreservingMethod extends Method { /** - * Holds if this callable returns precisely the value passed into argument `arg`. + * Holds if this method returns precisely the value passed into argument `arg`. * `arg` is a parameter index, or is -1 to indicate the qualifier. */ abstract predicate returnsValue(int arg); } /** - * A method or constructor that returns the exact value of its qualifier (e.g., `return this;`) + * A method that returns the exact value of its qualifier (e.g., `return this;`) * * Extend this class and override `returnsValue` to add additional value-preserving steps through a * method that should be added to the basic local flow step relation.