hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-26 01:05:15 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix protected internal on override in the same assembly

Browse Source
This commit is contained in:
Tamas Vajk
2021-04-16 15:36:54 +02:00
parent e6bfb0d1d2
commit 3c3ddcc8fb
1 changed files with 11 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
csharp/ql/src/Stubs/Stubs.qll
View File

@@ -260,6 +260,15 @@ private class DefaultLibs extends ExcludedAssembly {
}
}
private Virtualizable getAccessibilityDeclaringVirtualizable(Virtualizable v) {
if not v.isOverride()
then result = v
else
if not v.getOverridee().getLocation() instanceof ExcludedAssembly
then result = getAccessibilityDeclaringVirtualizable(v.getOverridee())
else result = v
}
private string stubAccessibility(Member m) {
if
m.getDeclaringType() instanceof Interface or
@@ -271,10 +280,10 @@ private string stubAccessibility(Member m) {
else
if m.isProtected()
then
if m.isPrivate()
if m.isPrivate() or getAccessibilityDeclaringVirtualizable(m).isPrivate()
then result = "protected private "
else
if m.isInternal()
if m.isInternal() or getAccessibilityDeclaringVirtualizable(m).isInternal()
then result = "protected internal "
else result = "protected "
else