hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-17 01:03:14 +01:00
Code Issues Packages Projects Releases Wiki Activity

rename decoratedRouteHandler to isDecoratedCall

Browse Source
This commit is contained in:
Erik Krogh Kristensen
2020-09-20 21:54:56 +02:00
parent 0b16f81f8b
commit 3aaa2d11a7
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
javascript/ql/src/semmle/javascript/frameworks/Express.qll
View File

@@ -76,10 +76,10 @@ module Express {
* Holds if `call` decorates the function `pred`.
* This means that `call` returns a function that forwards its arguments to `pred`.
*/
predicate decoratedRouteHandler(DataFlow::SourceNode pred, DataFlow::CallNode call) {
predicate isDecoratedCall(DataFlow::CallNode call, DataFlow::FunctionNode decoratee) {
// indirect route-handler `result` is given to function `outer`, which returns function `inner` which calls the function `pred`.
exists(int i, Function outer, Function inner |
pred = call.getArgument(i).getALocalSource() and
decoratee = call.getArgument(i).getALocalSource() and
outer = call.getACallee() and
inner = outer.getAReturnedExpr() and
forwardingCall(DataFlow::parameterNode(outer.getParameter(i)), inner.flow())
@@ -103,7 +103,7 @@ module Express {
* Holds if there exists a step from `pred` to `succ` for a RouteHandler - beyond the usual steps defined by TypeTracking.
*/
predicate routeHandlerStep(DataFlow::SourceNode pred, DataFlow::SourceNode succ) {
decoratedRouteHandler(pred, succ)
isDecoratedCall(succ, pred)
or
// A forwarding call
forwardingCall(pred, succ)

2
javascript/ql/src/semmle/javascript/frameworks/HTTP.qll
View File

@@ -596,7 +596,7 @@ module HTTP {
DataFlow::SourceNode getAPossiblyDecoratedHandler(RouteHandlerCandidate candidate) {
result = candidate
or
Express::decoratedRouteHandler(candidate, result)
Express::isDecoratedCall(result, candidate)
}
/**