hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-30 11:15:13 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1739 from hvitved/csharp/ssa/delegate-call-source

Browse Source 
C#: Search from delegate creation in `delegateCallSource()`
This commit is contained in:
Calum Grant
2019-08-20 15:16:20 +01:00
committed by GitHub
parent 7698240484 e4bd1980ab
commit 35017786cf
1 changed files with 9 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
csharp/ql/src/semmle/code/csharp/dataflow/SSA.qll
View File

@@ -1096,29 +1096,27 @@ module Ssa {
)
}
private predicate reachableFromDelegateCreation(Expr e) {
delegateCreation(e, _, _)
private predicate reachesDelegateCall(Expr e) {
delegateCall(_, e)
or
exists(Expr mid | reachableFromDelegateCreation(mid) | delegateFlowStep(mid, e))
exists(Expr mid | reachesDelegateCall(mid) | delegateFlowStep(e, mid))
}
pragma[noinline]
private predicate delegateFlowStepReachable(Expr pred, Expr succ) {
private predicate delegateFlowStepReaches(Expr pred, Expr succ) {
delegateFlowStep(pred, succ) and
reachableFromDelegateCreation(pred)
reachesDelegateCall(succ)
}
private Expr delegateCallSource(Call c) {
// Base case
delegateCall(c, result)
private Expr delegateCallSource(Callable c) {
delegateCreation(result, c, _)
or
// Recursive case
delegateFlowStepReachable(result, delegateCallSource(c))
delegateFlowStepReaches(delegateCallSource(c), result)
}
/** Gets a run-time target for the delegate call `c`. */
Callable getARuntimeDelegateTarget(Call c) {
delegateCreation(delegateCallSource(c), result, _)
delegateCall(c, delegateCallSource(result))
}
}