hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-05-02 12:15:17 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #4593 from asgerf/js/react-hot

Browse Source 
Approved by erik-krogh
This commit is contained in:
CodeQL CI
2020-11-25 12:01:38 +00:00
committed by GitHub
parent 7791ec3084 f894cf2074
commit 34ffcb5677
3 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
javascript/change-notes/2020-11-11-react-hot-loader.md Normal file
View File

@@ -0,0 +1,2 @@
lgtm,codescanning
* Hot-reloading React component are now recognized. Affects the package `react-hot-loader`.

2
javascript/ql/src/semmle/javascript/frameworks/React.qll
View File

@@ -742,6 +742,8 @@ private DataFlow::SourceNode higherOrderComponentBuilder() {
or
result = DataFlow::moduleMember("react-redux", "connect").getACall()
or
result = DataFlow::moduleMember(["react-hot-loader", "react-hot-loader/root"], "hot").getACall()
or
result = reactRouterDom().getAPropertyRead("withRouter")
or
exists(FunctionCompositionCall compose |

3
javascript/ql/test/library-tests/frameworks/ReactJS/higherOrderComponent.jsx
View File

@@ -3,6 +3,7 @@ import { connect } from 'react-redux';
import { compose } from 'redux';
import styled from 'styled-components';
import unknownFunction from 'somewhere';
import { hot } from 'react-hot-loader';
import { MyComponent } from './exportedComponent';
@@ -21,4 +22,4 @@ const withConnect = connect(mapStateToProps, mapDispatchToProps);
const ConnectedComponent = compose(withConnect, unknownFunction)(StyledComponent);
export default memo(ConnectedComponent);
export default hot(module)(memo(ConnectedComponent));