hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-05-01 03:35:13 +02:00
Code Issues Packages Projects Releases Wiki Activity

CPP: Guard the delete.

Browse Source
This commit is contained in:
Geoffrey White
2019-04-05 10:00:55 +01:00
parent cb09d23069
commit 34fbc7b194
4 changed files with 14 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
cpp/ql/test/examples/BadLocking/AV Rule 107.expected
View File

@@ -1,2 +1,2 @@
| UnintendedDeclaration.cpp:48:2:48:22 | declaration | Functions should be declared at file scope, not inside blocks. |
| UnintendedDeclaration.cpp:69:2:69:27 | declaration | Functions should be declared at file scope, not inside blocks. |
| UnintendedDeclaration.cpp:51:2:51:22 | declaration | Functions should be declared at file scope, not inside blocks. |
| UnintendedDeclaration.cpp:72:2:72:27 | declaration | Functions should be declared at file scope, not inside blocks. |

14
cpp/ql/test/examples/BadLocking/DeclStmts.expected
View File

@@ -1,7 +1,7 @@
| UnintendedDeclaration.cpp:41:2:41:29 | declaration | myLock | Variable |
| UnintendedDeclaration.cpp:48:2:48:22 | declaration | myLock | Function |
| UnintendedDeclaration.cpp:55:2:55:20 | declaration | myLock | Variable |
| UnintendedDeclaration.cpp:62:2:62:22 | declaration | myMutex | Variable |
| UnintendedDeclaration.cpp:69:2:69:27 | declaration | myLock | Function |
| UnintendedDeclaration.cpp:79:3:79:34 | declaration | myLock | Variable |
| UnintendedDeclaration.cpp:86:3:86:27 | declaration | memberMutex | Variable |
| UnintendedDeclaration.cpp:44:2:44:29 | declaration | myLock | Variable |
| UnintendedDeclaration.cpp:51:2:51:22 | declaration | myLock | Function |
| UnintendedDeclaration.cpp:58:2:58:20 | declaration | myLock | Variable |
| UnintendedDeclaration.cpp:65:2:65:22 | declaration | myMutex | Variable |
| UnintendedDeclaration.cpp:72:2:72:27 | declaration | myLock | Function |
| UnintendedDeclaration.cpp:82:3:82:34 | declaration | myLock | Variable |
| UnintendedDeclaration.cpp:89:3:89:27 | declaration | memberMutex | Variable |

2
cpp/ql/test/examples/BadLocking/LocalVariableHidesGlobalVariable.expected
View File

@@ -1 +1 @@
| UnintendedDeclaration.cpp:62:14:62:20 | definition of myMutex | Local variable myMutex hides $@ with the same name. | UnintendedDeclaration.cpp:37:7:37:13 | myMutex | a global variable |
| UnintendedDeclaration.cpp:65:14:65:20 | definition of myMutex | Local variable myMutex hides $@ with the same name. | UnintendedDeclaration.cpp:40:7:40:13 | myMutex | a global variable |

5
cpp/ql/test/examples/BadLocking/UnintendedDeclaration.cpp
View File

@@ -27,7 +27,10 @@ public:
~Lock()
{
m->unlock();
if (m)
{
m->unlock();
}
}
private: