hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-21 03:06:31 +01:00
Code Issues Packages Projects Releases Wiki Activity

DataFlow: s/flowThroughStepAllowed/validParameterAliasStep.

Browse Source
This commit is contained in:
Mathias Vorreiter Pedersen
2023-11-28 13:40:19 +00:00
parent e47ad274ea
commit 339bf1363a
4 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/DataFlowImplSpecific.qll
View File

@@ -21,5 +21,5 @@ module CppDataFlow implements InputSig {
predicate getAdditionalFlowIntoCallNodeTerm = Private::getAdditionalFlowIntoCallNodeTerm/2;
predicate flowThroughStepAllowed = Private::flowThroughStepAllowed/2;
predicate validParameterAliasStep = Private::validParameterAliasStep/2;
}

2
cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/DataFlowPrivate.qll
View File

@@ -1162,7 +1162,7 @@ private int countNumberOfBranchesUsingParameter(SwitchInstruction switch, Parame
*/
bindingset[node1, node2]
pragma[inline_late]
predicate flowThroughStepAllowed(Node node1, Node node2) {
predicate validParameterAliasStep(Node node1, Node node2) {
// When flow-through summaries are computed we track which parameters flow to out-going parameters.
// In an example such as:
// ```

2
shared/dataflow/codeql/dataflow/DataFlow.qll
View File

@@ -175,7 +175,7 @@ signature module InputSig {
* computing flow-through summaries.
*/
bindingset[node1, node2]
default predicate flowThroughStepAllowed(Node node1, Node node2) { any() }
default predicate validParameterAliasStep(Node node1, Node node2) { any() }
/**
* Holds if data can flow from `node1` to `node2` through a non-local step

4
shared/dataflow/codeql/dataflow/internal/DataFlowImplCommon.qll
View File

@@ -552,7 +552,7 @@ module MakeImplCommon<InputSig Lang> {
exists(Node mid |
parameterValueFlowCand(p, mid, read) and
simpleLocalFlowStep(mid, node) and
flowThroughStepAllowed(mid, node)
validParameterAliasStep(mid, node)
)
or
// read
@@ -672,7 +672,7 @@ module MakeImplCommon<InputSig Lang> {
exists(Node mid |
parameterValueFlow(p, mid, read) and
simpleLocalFlowStep(mid, node) and
flowThroughStepAllowed(mid, node)
validParameterAliasStep(mid, node)
)
or
// read