diff --git a/cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/DataFlowImplSpecific.qll b/cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/DataFlowImplSpecific.qll index ef0b0aa52a9..21328f881f1 100644 --- a/cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/DataFlowImplSpecific.qll +++ b/cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/DataFlowImplSpecific.qll @@ -21,5 +21,5 @@ module CppDataFlow implements InputSig { predicate getAdditionalFlowIntoCallNodeTerm = Private::getAdditionalFlowIntoCallNodeTerm/2; - predicate flowThroughStepAllowed = Private::flowThroughStepAllowed/2; + predicate validParameterAliasStep = Private::validParameterAliasStep/2; } diff --git a/cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/DataFlowPrivate.qll b/cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/DataFlowPrivate.qll index 8653a2d8b56..65aa3617824 100644 --- a/cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/DataFlowPrivate.qll +++ b/cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/DataFlowPrivate.qll @@ -1162,7 +1162,7 @@ private int countNumberOfBranchesUsingParameter(SwitchInstruction switch, Parame */ bindingset[node1, node2] pragma[inline_late] -predicate flowThroughStepAllowed(Node node1, Node node2) { +predicate validParameterAliasStep(Node node1, Node node2) { // When flow-through summaries are computed we track which parameters flow to out-going parameters. // In an example such as: // ``` diff --git a/shared/dataflow/codeql/dataflow/DataFlow.qll b/shared/dataflow/codeql/dataflow/DataFlow.qll index fb262a9d23b..062cd261a0d 100644 --- a/shared/dataflow/codeql/dataflow/DataFlow.qll +++ b/shared/dataflow/codeql/dataflow/DataFlow.qll @@ -175,7 +175,7 @@ signature module InputSig { * computing flow-through summaries. */ bindingset[node1, node2] - default predicate flowThroughStepAllowed(Node node1, Node node2) { any() } + default predicate validParameterAliasStep(Node node1, Node node2) { any() } /** * Holds if data can flow from `node1` to `node2` through a non-local step diff --git a/shared/dataflow/codeql/dataflow/internal/DataFlowImplCommon.qll b/shared/dataflow/codeql/dataflow/internal/DataFlowImplCommon.qll index 4098157d535..8955f3f6d51 100644 --- a/shared/dataflow/codeql/dataflow/internal/DataFlowImplCommon.qll +++ b/shared/dataflow/codeql/dataflow/internal/DataFlowImplCommon.qll @@ -552,7 +552,7 @@ module MakeImplCommon { exists(Node mid | parameterValueFlowCand(p, mid, read) and simpleLocalFlowStep(mid, node) and - flowThroughStepAllowed(mid, node) + validParameterAliasStep(mid, node) ) or // read @@ -672,7 +672,7 @@ module MakeImplCommon { exists(Node mid | parameterValueFlow(p, mid, read) and simpleLocalFlowStep(mid, node) and - flowThroughStepAllowed(mid, node) + validParameterAliasStep(mid, node) ) or // read