Merge pull request #20335 from michaelnebel/shared/ql4ql

Shared and Sync: Fix some Ql4Ql violations.
This commit is contained in:
Michael Nebel
2025-09-02 14:37:34 +02:00
committed by GitHub
4 changed files with 14 additions and 13 deletions

View File

@@ -4,7 +4,7 @@
/**
* Holds if the value at `(type, path)` should be seen as a flow
* source of the given `kind`.
* source of the given `kind` and `madId` is the data extension row number.
*
* The kind `remote` represents a general remote flow source.
*/
@@ -14,13 +14,14 @@ extensible predicate sourceModel(
/**
* Holds if the value at `(type, path)` should be seen as a sink
* of the given `kind`.
* of the given `kind` and `madId` is the data extension row number.
*/
extensible predicate sinkModel(string type, string path, string kind, QlBuiltins::ExtensionId madId);
/**
* Holds if in calls to `(type, path)`, the value referred to by `input`
* can flow to the value referred to by `output`.
* can flow to the value referred to by `output` and `madId` is the data
* extension row number.
*
* `kind` should be either `value` or `taint`, for value-preserving or taint-preserving steps,
* respectively.

View File

@@ -4,7 +4,7 @@
/**
* Holds if the value at `(type, path)` should be seen as a flow
* source of the given `kind`.
* source of the given `kind` and `madId` is the data extension row number.
*
* The kind `remote` represents a general remote flow source.
*/
@@ -14,13 +14,14 @@ extensible predicate sourceModel(
/**
* Holds if the value at `(type, path)` should be seen as a sink
* of the given `kind`.
* of the given `kind` and `madId` is the data extension row number.
*/
extensible predicate sinkModel(string type, string path, string kind, QlBuiltins::ExtensionId madId);
/**
* Holds if in calls to `(type, path)`, the value referred to by `input`
* can flow to the value referred to by `output`.
* can flow to the value referred to by `output` and `madId` is the data
* extension row number.
*
* `kind` should be either `value` or `taint`, for value-preserving or taint-preserving steps,
* respectively.

View File

@@ -4,7 +4,7 @@
/**
* Holds if the value at `(type, path)` should be seen as a flow
* source of the given `kind`.
* source of the given `kind` and `madId` is the data extension row number.
*
* The kind `remote` represents a general remote flow source.
*/
@@ -14,13 +14,14 @@ extensible predicate sourceModel(
/**
* Holds if the value at `(type, path)` should be seen as a sink
* of the given `kind`.
* of the given `kind` and `madId` is the data extension row number.
*/
extensible predicate sinkModel(string type, string path, string kind, QlBuiltins::ExtensionId madId);
/**
* Holds if in calls to `(type, path)`, the value referred to by `input`
* can flow to the value referred to by `output`.
* can flow to the value referred to by `output` and `madId` is the data
* extension row number.
*
* `kind` should be either `value` or `taint`, for value-preserving or taint-preserving steps,
* respectively.

View File

@@ -365,7 +365,7 @@ module CryptographyBase<LocationSig Location, InputSig<Location> Input> {
*/
abstract class ArtifactConsumer extends ConsumerElement {
/**
* Use `getAKnownArtifactSource() instead. The behaviour of these two predicates is equivalent.
* Use `getAKnownArtifactSource() instead. The behavior of these two predicates is equivalent.
*/
final override KnownElement getAKnownSource() { result = this.getAKnownArtifactSource() }
@@ -1841,9 +1841,7 @@ module CryptographyBase<LocationSig Location, InputSig<Location> Input> {
* An SCRYPT key derivation algorithm node.
*/
class ScryptAlgorithmNode extends KeyDerivationAlgorithmNode {
ScryptAlgorithmInstance scryptInstance;
ScryptAlgorithmNode() { scryptInstance = instance.asAlg() }
ScryptAlgorithmNode() { instance.asAlg() instanceof ScryptAlgorithmInstance }
/**
* Gets the iteration count (`N`) argument