hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-17 01:03:14 +01:00
Code Issues Packages Projects Releases Wiki Activity

Csharp: rename predicate

Browse Source
This commit is contained in:
Paolo Tranquilli
2025-10-21 11:47:21 +02:00
parent 6f8b1f6f4c
commit 316225bb88
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
csharp/ql/src/Security Features/CWE-451/MissingXFrameOptions.ql
View File

@@ -16,12 +16,12 @@ import csharp
import semmle.code.asp.WebConfig
import semmle.code.csharp.frameworks.system.Web
XmlElement getAWebServerConfig(WebConfigXml webConfig) {
XmlElement getAWebConfigRoot(WebConfigXml webConfig) {
result = webConfig.getARootElement()
or
result = webConfig.getARootElement().getAChild("location") and
(
not exists(result.getAttributeValue("path")) // equivalent to path="."
not result.hasAttribute("path") // equivalent to path="."
or
result.getAttributeValue("path") = ["", "."]
)
@@ -42,7 +42,7 @@ predicate hasWebConfigXFrameOptions(WebConfigXml webConfig) {
// </system.webServer>
// ```
// This can also be in a `location`
getAWebServerConfig(webConfig)
getAWebConfigRoot(webConfig)
.getAChild("system.webServer")
.getAChild("httpProtocol")
.getAChild("customHeaders")

2
csharp/ql/src/change-notes/2025-10-17-location-in-web-config.md
View File

@@ -1,4 +1,4 @@
---
category: minorAnalysis
---
* the `cs/web/missing-x-frame-options` query now correctly handles configuration nested in `<location>` elements.
* the `cs/web/missing-x-frame-options` query now correctly handles configuration nested in a `<location >` elements.