python: fix warnings

- rename `Conf` -> `Config`
- comment out unused code
- rearrange code so it is easy to see how to swap comments
- autoformat
This commit is contained in:
Rasmus Lerchedahl Petersen
2023-05-09 15:01:31 +02:00
parent e65ff68547
commit 30d3c3e8cd
2 changed files with 17 additions and 21 deletions

View File

@@ -12,26 +12,24 @@ import semmle.python.dataflow.new.DataFlow
import semmle.python.dataflow.new.TaintTracking
import experimental.meta.InlineTaintTest::Conf
module Conf implements DataFlow::ConfigSig {
module Config implements DataFlow::ConfigSig {
predicate isSource(DataFlow::Node source) {
any (TestTaintTrackingConfiguration c).isSource(source)
}
predicate isSink(DataFlow::Node source) {
any (TestTaintTrackingConfiguration c).isSink(source)
any(TestTaintTrackingConfiguration c).isSource(source)
}
predicate isSink(DataFlow::Node source) { any(TestTaintTrackingConfiguration c).isSink(source) }
}
int explorationLimit() { result = 5 }
module Flows = TaintTracking::Global<Conf>;
module Flows = TaintTracking::Global<Config>;
module FlowsPartial = Flows::FlowExploration<explorationLimit/0>;
// import FlowsPartial::PartialPathGraph
import Flows::PathGraph
// from FlowsPartial::PartialPathNode source, FlowsPartial::PartialPathNode sink
// where FlowsPartial::partialFlow(source, sink, _)
// int explorationLimit() { result = 5 }
// module FlowsPartial = Flows::FlowExploration<explorationLimit/0>;
// import FlowsPartial::PartialPathGraph
from Flows::PathNode source, Flows::PathNode sink
where Flows::flowPath(source, sink)
// from FlowsPartial::PartialPathNode source, FlowsPartial::PartialPathNode sink
// where FlowsPartial::partialFlow(source, sink, _)
select sink.getNode(), source, sink, "This node receives taint from $@.", source.getNode(),
"this source"

View File

@@ -11,24 +11,22 @@ import python
import semmle.python.dataflow.new.DataFlow
import experimental.dataflow.testConfig
module Conf implements DataFlow::ConfigSig {
module Config implements DataFlow::ConfigSig {
predicate isSource(DataFlow::Node source) { any(TestConfiguration c).isSource(source) }
predicate isSink(DataFlow::Node source) { any(TestConfiguration c).isSink(source) }
}
int explorationLimit() { result = 5 }
module Flows = DataFlow::Global<Config>;
module Flows = DataFlow::Global<Conf>;
module FlowsPartial = Flows::FlowExploration<explorationLimit/0>;
// import FlowsPartial::PartialPathGraph
import Flows::PathGraph
// from FlowsPartial::PartialPathNode source, FlowsPartial::PartialPathNode sink
// where FlowsPartial::partialFlow(source, sink, _)
// int explorationLimit() { result = 5 }
// module FlowsPartial = Flows::FlowExploration<explorationLimit/0>;
// import FlowsPartial::PartialPathGraph
from Flows::PathNode source, Flows::PathNode sink
where Flows::flowPath(source, sink)
// from FlowsPartial::PartialPathNode source, FlowsPartial::PartialPathNode sink
// where FlowsPartial::partialFlow(source, sink, _)
select sink.getNode(), source, sink, "This node receives flow from $@.", source.getNode(),
"this source"