hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-17 01:03:14 +01:00
Code Issues Packages Projects Releases Wiki Activity

C#: Tidy up docs, query metadata and add tests.

Browse Source
This commit is contained in:
Calum Grant
2019-11-28 15:18:32 +00:00
parent eeffd7cf8d
commit 30a2620a8c
11 changed files with 45 additions and 52 deletions
Download Patch File Download Diff File Expand all files Collapse all files

44
csharp/ql/src/Security Features/CWE-016/ASPNetPagesValidateRequest.qhelp
View File

@@ -1,14 +1,10 @@
<!DOCTYPE qhelp PUBLIC
"-//Semmle//qhelp//EN"
"qhelp.dtd">
<!DOCTYPE qhelp PUBLIC "-//Semmle//qhelp//EN" "qhelp.dtd">
<qhelp>
<overview>
<p>
<code>Request validation</code>
is a feature in ASP.NET that protects web applications against
potentially malicious content
in requests, specifically against
Request validation is a feature in ASP.NET that protects web applications against
potentially malicious content in requests, specifically against
cross-site scripting attacks (XSS).
</p>
@@ -16,9 +12,10 @@
<recommendation>
<p>
Enable the directive validateRequest in your web.config file:
Enable the directive <code>validateRequest</code> in your <code>web.config</code> file:
<code>
<pages validateRequest="true" />
&lt;pages validateRequest="true" /&gt;
</code>
</p>
@@ -26,22 +23,18 @@
<example>
<p>
The following example shows the 'validateRequest' flag set to true in
a
<code>Web.config</code>
file for ASP.NET. This will protect the web application against
common XSS attacks:
The following example shows the <code>validateRequest</code> flag set to <code>false</code>
in a <code>Web.config</code> file for ASP.NET. This will disable validation, and leave
the the web application vulnerable against common XSS attacks:
</p>
<sample src="Web.config.ASPNetPagesValidateRequest.good" />
<sample src="ASPNetPagesValidateRequestBad.config" />
<p>
If validateRequest is set to
<code>false</code>
, validation is disabled:
If validateRequest is set to <code>true</code>, validation is enabled:
</p>
<sample src="Web.config.ASPNetPagesValidateRequest.bad" />
<sample src="ASPNetPagesValidateRequestGood.config" />
</example>
<references>
@@ -49,17 +42,10 @@
<li>
MSDN:
<a
href=https://docs.microsoft.com/en-us/previous-versions/aspnet/hh882339(v=vs.110)?redirectedfrom=MSDN ">Request
Validation in ASP.NET</a>
.
href="https://docs.microsoft.com/en-us/previous-versions/aspnet/hh882339(v=vs.110)?redirectedfrom=MSDN">
Request Validation in ASP.NET
</a>.
</li>
<li>
MSDN:
<a
href="https://docs.microsoft.com/en-us/previous-versions/aspnet/debza5t0(v=vs.100)?redirectedfrom=MSDN">Validation ASP.NET Controls</a>
.
</li>
</references>
</qhelp>

11
csharp/ql/src/Security Features/CWE-016/ASPNetPagesValidateRequest.ql
View File

@@ -1,7 +1,12 @@
/**
* @name Page Request Validation is disabled
* @description ASP.NET Pages should not disable the built-in request validation.
* @name Page request validation is disabled
* @description ASP.NET pages should not disable the built-in request validation.
* @kind problem
* @problem.severity warning
* @id cs/web/request-validation-disabled
* @tags security
* frameworks/asp.net
* external/cwe/cwe-16
*/
import csharp
@@ -11,4 +16,4 @@ from SystemWebXMLElement web, XMLAttribute requestvalidateAttribute
where
requestvalidateAttribute = web.getAChild("pages").getAttribute("validateRequest") and
requestvalidateAttribute.getValue().toLowerCase() = "false"
select requestvalidateAttribute, "validateRequest is set to false"
select requestvalidateAttribute, "The 'validateRequest' attribute is set to 'false'."

5
csharp/ql/src/Security Features/CWE-016/ASPNetPagesValidateRequestBad.config Normal file
View File

@@ -0,0 +1,5 @@
<configuration>
<system.web>
<pages validateRequest="false" />
</system.web>
</configuration>

5
csharp/ql/src/Security Features/CWE-016/ASPNetPagesValidateRequestGood.config Normal file
View File

@@ -0,0 +1,5 @@
<configuration>
<system.web>
<pages validateRequest="true" />
</system.web>
</configuration>

10
csharp/ql/src/Security Features/CWE-016/Web.config.ASPNetPagesValidateRequest.bad
View File

@@ -1,10 +0,0 @@
<?xml version="1.0" encoding="utf-8" ?>
<configuration>
<system.web>
<compilation
defaultLanguage="c#"
/>
<pages validateRequest="false" />
...
</system.web>
</configuration>

10
csharp/ql/src/Security Features/CWE-016/Web.config.ASPNetPagesValidateRequest.good
View File

@@ -1,10 +0,0 @@
<?xml version="1.0" encoding="utf-8" ?>
<configuration>
<system.web>
<compilation
defaultLanguage="c#"
/>
<pages validateRequest="true" />
...
</system.web>
</configuration>

1
csharp/ql/test/query-tests/Security Features/CWE-016/ASPNetPagesValidateRequest/ASPNetPagesValidateRequest.expected Normal file
View File

@@ -0,0 +1 @@
| ASPNetPagesValidateRequestBad.config:3:5:3:38 | validateRequest=false | The 'validateRequest' attribute is set to 'false'. |

1
csharp/ql/test/query-tests/Security Features/CWE-016/ASPNetPagesValidateRequest/ASPNetPagesValidateRequest.qlref Normal file
View File

@@ -0,0 +1 @@
Security Features/CWE-016/ASPNetPagesValidateRequest.ql

5
csharp/ql/test/query-tests/Security Features/CWE-016/ASPNetPagesValidateRequest/ASPNetPagesValidateRequestBad.config Normal file
View File

@@ -0,0 +1,5 @@
<configuration>
<system.web>
<pages validateRequest="false" />
</system.web>
</configuration>

5
csharp/ql/test/query-tests/Security Features/CWE-016/ASPNetPagesValidateRequest/ASPNetPagesValidateRequestGood.config Normal file
View File

@@ -0,0 +1,5 @@
<configuration>
<system.web>
<pages validateRequest="true" />
</system.web>
</configuration>

0
csharp/ql/test/query-tests/Security Features/CWE-016/ASPNetPagesValidateRequest/Program.cs Normal file
View File