hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-30 19:26:02 +02:00
Code Issues Packages Projects Releases Wiki Activity

C++: Improve the changes to Iterator.

Browse Source
This commit is contained in:
Geoffrey White
2020-11-10 15:30:47 +00:00
parent c635166079
commit 2c7a01952e
1 changed files with 7 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
cpp/ql/src/semmle/code/cpp/models/implementations/Iterator.qll
View File

@@ -29,7 +29,7 @@ private class IteratorTraits extends Class {
/**
* A type which has the typedefs expected for an iterator.
*/
private class IteratorByTypedefs extends Class {
private class IteratorByTypedefs extends Iterator, Class {
IteratorByTypedefs() {
this.getAMember().(TypedefType).hasName("difference_type") and
this.getAMember().(TypedefType).hasName("value_type") and
@@ -43,18 +43,17 @@ private class IteratorByTypedefs extends Class {
/**
* The `std::iterator` class.
*/
private class StdIterator extends Class {
private class StdIterator extends Iterator, Class {
StdIterator() { this.hasQualifiedName("std", "iterator") }
}
/**
* Implements `Iterator`.
* A type that is deduced to be an iterator because there is a corresponding
* `std::iterator_traits` instantiation for it.
*/
private class IteratorImpl extends Iterator {
IteratorImpl() {
this instanceof IteratorByTypedefs or
exists(IteratorTraits it | it.getIteratorType() = this) or
this instanceof StdIterator
private class IteratorByTraits extends Iterator {
IteratorByTraits() {
exists(IteratorTraits it | it.getIteratorType() = this)
}
}