hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-16 16:53:25 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix a bad join order on locations.

Browse Source
This commit is contained in:
Alex Eyers-Taylor
2025-04-04 16:55:30 +01:00
parent 29fcbe3c8f
commit 2c3442d4eb
1 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
javascript/ql/src/Statements/LabelInCase.ql
View File

@@ -12,8 +12,11 @@
import javascript import javascript
from LabeledStmt l, Case c int labelInCaseStartColumn(Case c, LabeledStmt l) {
where
l = c.getAChildStmt+() and l = c.getAChildStmt+() and
l.getLocation().getStartColumn() = c.getLocation().getStartColumn() result = l.getLocation().getStartColumn()
}
from LabeledStmt l, Case c
where labelInCaseStartColumn(c, l) = c.getLocation().getStartColumn()
select l.getChildExpr(0), "Non-case labels in switch statements are confusing." select l.getChildExpr(0), "Non-case labels in switch statements are confusing."