From 2c3442d4ebf13770294962b5aa1058dbe4386b1e Mon Sep 17 00:00:00 2001 From: Alex Eyers-Taylor Date: Fri, 4 Apr 2025 16:55:30 +0100 Subject: [PATCH] Fix a bad join order on locations. --- javascript/ql/src/Statements/LabelInCase.ql | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/javascript/ql/src/Statements/LabelInCase.ql b/javascript/ql/src/Statements/LabelInCase.ql index e88d366136f..65fc230a819 100644 --- a/javascript/ql/src/Statements/LabelInCase.ql +++ b/javascript/ql/src/Statements/LabelInCase.ql @@ -12,8 +12,11 @@ import javascript -from LabeledStmt l, Case c -where +int labelInCaseStartColumn(Case c, LabeledStmt l) { l = c.getAChildStmt+() and - l.getLocation().getStartColumn() = c.getLocation().getStartColumn() + result = l.getLocation().getStartColumn() +} + +from LabeledStmt l, Case c +where labelInCaseStartColumn(c, l) = c.getLocation().getStartColumn() select l.getChildExpr(0), "Non-case labels in switch statements are confusing."