hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-24 08:15:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

C#: Disregards compiler generated virtual calls as problematic virtual calls.

Browse Source
This commit is contained in:
Michael Nebel
2025-01-13 10:13:03 +01:00
parent 77f9f4c532
commit 2bff2d646f
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
csharp/ql/src/Bad Practices/VirtualCallInConstructorOrDestructor.ql
View File

@@ -34,7 +34,9 @@ predicate overriddenSealed(RefType t, Virtualizable d) {
}
predicate virtualAccessWithThisQualifier(Expr e, Member d) {
exists(VirtualMethodCall c | c = e and c.getTarget() = d and c.hasThisQualifier())
exists(VirtualMethodCall c |
c = e and c.getTarget() = d and c.hasThisQualifier() and not c.isImplicit()
)
or
exists(VirtualMethodAccess c | c = e and c.getTarget() = d and c.hasThisQualifier())
or