hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-05-04 13:15:21 +02:00
Code Issues Packages Projects Releases Wiki Activity

Java: Address comments.

Browse Source
This commit is contained in:
Anders Schack-Mulligen
2019-10-14 14:59:14 +02:00
parent 312c573eb6
commit 2be5c38615
1 changed files with 7 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
java/ql/src/semmle/code/java/dataflow/internal/DataFlowPrivate.qll
View File

@@ -286,7 +286,7 @@ class DataFlowCall extends Call {
ExprNode getNode() { result.getExpr() = this }
}
/** Holds if `e` is an expression that always has the same boolean value `val`. */
/** Holds if `e` is an expression that always has the same Boolean value `val`. */
private predicate constantBooleanExpr(Expr e, boolean val) {
e.(CompileTimeConstantExpr).getBooleanValue() = val
or
@@ -297,11 +297,11 @@ private predicate constantBooleanExpr(Expr e, boolean val) {
)
}
/** An expression that always has the same boolean value. */
class ConstantBooleanExprNode extends ArgumentNode, ExprNode {
ConstantBooleanExprNode() { constantBooleanExpr(this.getExpr(), _) }
/** An argument that always has the same Boolean value. */
private class ConstantBooleanArgumentNode extends ArgumentNode, ExprNode {
ConstantBooleanArgumentNode() { constantBooleanExpr(this.getExpr(), _) }
/** Gets the boolean value of this expression. */
/** Gets the Boolean value of this expression. */
boolean getBooleanValue() { constantBooleanExpr(this.getExpr(), result) }
}
@@ -311,7 +311,8 @@ class ConstantBooleanExprNode extends ArgumentNode, ExprNode {
cached
predicate isUnreachableInCall(Node n, DataFlowCall call) {
exists(
ExplicitParameterNode paramNode, ConstantBooleanExprNode arg, SsaImplicitInit param, Guard guard
ExplicitParameterNode paramNode, ConstantBooleanArgumentNode arg, SsaImplicitInit param,
Guard guard
|
// get constant bool argument and parameter for this call
viableParamArg(call, paramNode, arg) and