hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-26 01:05:15 +02:00
Code Issues Packages Projects Releases Wiki Activity

C#: Re-factor.

Browse Source
This commit is contained in:
Michael Nebel
2023-06-08 19:02:07 +02:00
parent d882fe1ea8
commit 2a1c0e8ba6
1 changed files with 28 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

51
csharp/ql/lib/semmle/code/csharp/frameworks/EntityFramework.qll
View File

@@ -339,7 +339,7 @@ module EntityFramework {
* Gets the string representation for synthetic identifiers for SaveChanges methods
* on this.
*/
string getSyntheticNames() {
private string getSyntheticNames() {
exists(string qualifier, string type, string name |
this.getASaveChanges().hasQualifiedName(qualifier, type, name)
|
@@ -381,6 +381,17 @@ module EntityFramework {
this.stepRev(tailHead, tailType, head, headType, dist)
)
}
pragma[nomagic]
string getInputSynthetic(SummaryComponentStack output, DbContextClassSetProperty p) {
exists(SummaryComponentStack synthetic, Property mapped |
this = p.getDbContextClass() and
input(this, synthetic, mapped) and
output(this, output, mapped, p) and
result =
getFullSyntheticName(this.getSyntheticNames(), p.getSyntheticName(), synthetic, output)
)
}
}
private class DbContextClassSetProperty extends Property {
@@ -454,12 +465,9 @@ module EntityFramework {
override predicate propagatesFlow(
SummaryComponentStack input, SummaryComponentStack output, boolean preservesValue
) {
exists(SummaryComponentStack synthetic, string name, DbContextClass c, Property mapped |
exists(string name, DbContextClass c |
preservesValue = true and
c = p.getDbContextClass() and
input(c, synthetic, mapped) and
output(c, output, mapped, p) and
name = getFullSyntheticName(c.getSyntheticNames(), p.getSyntheticName(), synthetic, output) and
name = c.getInputSynthetic(output, p) and
input = SummaryComponentStack::syntheticGlobal(name)
)
}
@@ -478,18 +486,22 @@ module EntityFramework {
)
}
pragma[nomagic]
string getOutputSynthetic(SummaryComponentStack input) {
exists(SummaryComponentStack synthetic, Property mapped, DbContextClassSetProperty dbSet |
input(c, input, mapped) and
output(c, synthetic, mapped, dbSet) and
result =
getFullSyntheticName(this.getSyntheticName(), dbSet.getSyntheticName(), input, synthetic)
)
}
override predicate propagatesFlow(
SummaryComponentStack input, SummaryComponentStack output, boolean preservesValue
) {
exists(
SummaryComponentStack synthetic, string name, Property mapped,
DbContextClassSetProperty dbSet
|
exists(string name |
preservesValue = true and
input(c, input, mapped) and
output(c, synthetic, mapped, dbSet) and
name =
getFullSyntheticName(this.getSyntheticName(), dbSet.getSyntheticName(), input, synthetic) and
name = this.getOutputSynthetic(input) and
output = SummaryComponentStack::syntheticGlobal(name)
)
}
@@ -500,15 +512,8 @@ module EntityFramework {
*/
private class EFSummarizedCallableSyntheticGlobal extends SummaryComponent::SyntheticGlobal {
EFSummarizedCallableSyntheticGlobal() {
exists(
DbContextClass c, SummaryComponentStack input, SummaryComponentStack output,
Property mapped, DbContextClassSetProperty dbSet
|
input(c, input, mapped) and
output(c, output, mapped, dbSet)
|
this = getFullSyntheticName(c.getSyntheticNames(), dbSet.getSyntheticName(), input, output)
)
this = any(DbContextClass c).getInputSynthetic(_, _) or
this = any(DbContextSaveChanges c).getOutputSynthetic(_)
}
}