mirror of
https://github.com/github/codeql.git
synced 2025-12-16 16:53:25 +01:00
Revert "Swift: auto-flush logs at exit"
This reverts commit 0d9dcb161f.
This turns out to introduce a subtle bug related to destruction order
between `Log::instance()` and the `Logger` instances.
This commit is contained in:
@@ -227,5 +227,7 @@ int main(int argc, char** argv, char** envp) {
|
||||
observer.markSuccessfullyExtractedFiles();
|
||||
}
|
||||
|
||||
codeql::Log::flush();
|
||||
|
||||
return frontend_rc;
|
||||
}
|
||||
|
||||
@@ -110,8 +110,6 @@ class Log {
|
||||
Level level;
|
||||
};
|
||||
|
||||
~Log() { flushImpl(); }
|
||||
|
||||
// Flush logs to the designated outputs
|
||||
static void flush() { instance().flushImpl(); }
|
||||
|
||||
|
||||
@@ -72,6 +72,7 @@ void buildTarget(Target& target, bool dryRun) {
|
||||
if (!exec(argv)) {
|
||||
DIAGNOSE_ERROR(build_command_failed, "The detected build command failed (tried {})",
|
||||
absl::StrJoin(argv, " "));
|
||||
codeql::Log::flush();
|
||||
exit(1);
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user