hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-25 08:45:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

Apply code review findings

Browse Source
This commit is contained in:
Tamas Vajk
2021-06-16 10:26:27 +02:00
parent c5b8acf216
commit 28ef0e86f6
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
csharp/ql/src/semmle/code/csharp/Member.qll
View File

@@ -109,7 +109,7 @@ class Modifiable extends Declaration, @modifiable {
* - the declaring and its nested types, similarly to `private` declarations, and
* - the enclosing types.
*
* Note that explicit interface implementation are also considered effectively
* Note that explicit interface implementations are also considered effectively
* `private` if the implemented interface is itself effectively `private`. Finally,
* `private protected` members are not considered effectively `private`, because
* they can be overriden within the declaring assembly.
@@ -135,7 +135,7 @@ class Modifiable extends Declaration, @modifiable {
* effectively `internal` if it can only be referenced from the declaring assembly.
*
* Note that friend assemblies declared in `InternalsVisibleToAttribute` are not
* considered. Explicit interface implementation are also considered effectively
* considered. Explicit interface implementations are also considered effectively
* `internal` if the implemented interface is itself effectively `internal`. Finally,
* `internal protected` members are not considered effectively `internal`, because
* they can be overriden outside the declaring assembly.
@@ -192,7 +192,7 @@ class Virtualizable extends Member, @virtualizable {
}
override predicate isPrivate() {
Member.super.isPrivate() and
super.isPrivate() and
not implementsExplicitInterface()
}