hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-30 11:15:13 +02:00
Code Issues Packages Projects Releases Wiki Activity

C++: Fix explicit this-> FP.

Browse Source
This commit is contained in:
Nora Dimitrijević
2022-09-29 17:04:11 +02:00
parent 29d7c0e21b
commit 28bd591107
2 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
cpp/ql/src/Best Practices/Likely Errors/CommaBeforeMisleadingIndentation.ql
View File

@@ -13,10 +13,10 @@ import semmle.code.cpp.commons.Exclusions
/** Gets the sub-expression of 'e' with the earliest-starting Location */
Expr normalizeExpr(Expr e) {
if forex(Expr q | q = e.(Call).getQualifier() | not q instanceof ThisExpr)
if forex(Expr q | q = e.(Call).getQualifier() | not q.(ThisExpr).isCompilerGenerated())
then result = normalizeExpr(e.(Call).getQualifier())
else
if forex(Expr q | q = e.(FieldAccess).getQualifier() | not q instanceof ThisExpr)
if forex(Expr q | q = e.(FieldAccess).getQualifier() | not q.(ThisExpr).isCompilerGenerated())
then result = normalizeExpr(e.(FieldAccess).getQualifier())
else
if e.hasExplicitConversion()

4
cpp/ql/test/query-tests/Best Practices/Likely Errors/CommaBeforeMisleadingIndentation/test.cpp
View File

@@ -40,6 +40,10 @@ int Foo::test(int (*baz)(int))
(void)i, // GOOD
(void)j;
if (i)
this->foo(i), // GOOD
foo(i);
if (i)
(void)i, // BAD
(void)j;