hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-24 04:36:35 +01:00
Code Issues Packages Projects Releases Wiki Activity

Apply suggestions from code review

Browse Source 
Co-authored-by: Steve Guntrip <12534592+stevecat@users.noreply.github.com>
This commit is contained in:
Tony Torralba
2021-08-19 16:43:39 +02:00
parent aa2cdb7a53
commit 28369d1822
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
java/ql/src/Security/CWE/CWE-940/AndroidIntentRedirection.qhelp
View File

@@ -6,14 +6,15 @@
on behalf of the victim app.</p> on behalf of the victim app.</p>
</overview> </overview>
<recommendation> <recommendation>
<p>Do not export compontents that start other components from a user-provided Intent. <p>Do not export components that start other components from a user-provided Intent.
They can be made private by setting the <code>android:exported</code> property to <code>false</code> in the app's Android Manifest.</p> They can be made private by setting the <code>android:exported</code> property to <code>false</code> in the app's Android Manifest.</p>
<p>If this is not possible, restrict either which apps can send Intents to the affected component, or which components can be started from it.</p> <p>If this is not possible, restrict either which apps can send Intents to the affected component, or which components can be started from it.</p>
</recommendation> </recommendation>
<example> <example>
<p>The following snippet contains two examples. <p>The following snippet contains two examples.
In the first example, an arbitrary component can be started from the externally provided <code>forward_intent</code> Intent. In the first example, an arbitrary component can be started from the externally provided <code>forward_intent</code> Intent.
In the second example, the destination component of the Intent is first checked to make sure it is safe.</p> In the second example, the destination component of the Intent is first checked to make sure it is safe.
In the third example, the component that created the Intent is first checked to make sure it comes from a trusted origin.</p>
<sample src="AndroidIntentRedirectionSample.java" /> <sample src="AndroidIntentRedirectionSample.java" />
</example> </example>
<references> <references>