diff --git a/java/ql/src/Security/CWE/CWE-940/AndroidIntentRedirection.qhelp b/java/ql/src/Security/CWE/CWE-940/AndroidIntentRedirection.qhelp index eb3f61f3bb5..47ba77b6e25 100644 --- a/java/ql/src/Security/CWE/CWE-940/AndroidIntentRedirection.qhelp +++ b/java/ql/src/Security/CWE/CWE-940/AndroidIntentRedirection.qhelp @@ -6,14 +6,15 @@ on behalf of the victim app.

-

Do not export compontents that start other components from a user-provided Intent. +

Do not export components that start other components from a user-provided Intent. They can be made private by setting the android:exported property to false in the app's Android Manifest.

If this is not possible, restrict either which apps can send Intents to the affected component, or which components can be started from it.

The following snippet contains two examples. In the first example, an arbitrary component can be started from the externally provided forward_intent Intent. - In the second example, the destination component of the Intent is first checked to make sure it is safe.

+ In the second example, the destination component of the Intent is first checked to make sure it is safe. + In the third example, the component that created the Intent is first checked to make sure it comes from a trusted origin.