hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-28 18:25:24 +02:00
Code Issues Packages Projects Releases Wiki Activity

Ruby: inline RenderCallUtils::getBaseName

Browse Source 
This seems to yield a small performance increase.
This commit is contained in:
Harry Maclean
2023-02-04 12:02:33 +13:00
parent ae3d91b546
commit 2590682262
1 changed files with 3 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
ruby/ql/lib/codeql/ruby/frameworks/Rails.qll
View File

@@ -29,16 +29,13 @@ private module RenderCallUtils {
result = getTemplatePathValue(renderCall).regexpCapture("^/?(.*/)?(?:[^/]*?)$", 1)
}
// everything after the final slash, or the whole string if there is no slash
private string getBaseName(MethodCall renderCall) {
result = getTemplatePathValue(renderCall).regexpCapture("^/?(?:.*/)?([^/]*?)$", 1)
}
/**
* Gets the template file to be rendered by this render call, if any.
*/
ErbFile getTemplateFile(MethodCall renderCall) {
result.getTemplateName() = getBaseName(renderCall) and
// everything after the final slash, or the whole string if there is no slash
result.getTemplateName() =
getTemplatePathValue(renderCall).regexpCapture("^/?(?:.*/)?([^/]*?)$", 1) and
result.getRelativePath().matches("%app/views/" + getSubPath(renderCall) + "%")
}