hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-30 11:15:13 +02:00
Code Issues Packages Projects Releases Wiki Activity

add a few more tests, and some clean-up

Browse Source
This commit is contained in:
Jami Cogswell
2022-09-22 11:44:03 -04:00
parent 7a96727c59
commit 24b34cd32f
4 changed files with 58 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
java/ql/lib/semmle/code/java/frameworks/android/Intent.qll
View File

@@ -65,9 +65,8 @@ class AndroidReceiveIntentMethod extends Method {
}
/**
* A method of type Service that receives an Intent.
* Namely, `Service.onStart`, `onStartCommand`, `onBind`,
* `onRebind`, `onUnbind`, or `onTaskRemoved`
* The method `Service.onStart`, `onStartCommand`,
* `onBind`, `onRebind`, `onUnbind`, or `onTaskRemoved`
*/
class AndroidServiceIntentMethod extends Method {
AndroidServiceIntentMethod() {

1
java/ql/test/library-tests/dataflow/taintsources/IntentSourcesActivity.java
View File

@@ -1,7 +1,6 @@
package com.example.myapp;
import android.app.Activity;
import android.content.Intent;
public class IntentSourcesActivity extends Activity {

10
java/ql/test/library-tests/dataflow/taintsources/IntentSourcesReceiver.java
View File

@@ -11,7 +11,13 @@ public class IntentSourcesReceiver extends BroadcastReceiver {
@Override
public void onReceive(Context context, Intent intent) {
String trouble = intent.getStringExtra("data");
sink(trouble); // $ hasRemoteTaintFlow
{
String trouble = intent.getStringExtra("data");
sink(trouble); // $ hasRemoteTaintFlow
}
{
String trouble = intent.getExtras().getString("data");
sink(trouble); // $ hasRemoteTaintFlow
}
}
}

60
java/ql/test/library-tests/dataflow/taintsources/IntentSourcesService.java
View File

@@ -12,41 +12,77 @@ public class IntentSourcesService extends Service {
@Override
public void onStart(Intent intent, int startId) {
String trouble = intent.getStringExtra("data");
sink(trouble); // $ hasRemoteTaintFlow
{
String trouble = intent.getStringExtra("data");
sink(trouble); // $ hasRemoteTaintFlow
}
{
String trouble = intent.getExtras().getString("data");
sink(trouble); // $ hasRemoteTaintFlow
}
}
@Override
public int onStartCommand(Intent intent, int flags, int startId) {
String trouble = intent.getStringExtra("data");
sink(trouble); // $ hasRemoteTaintFlow
{
String trouble = intent.getStringExtra("data");
sink(trouble); // $ hasRemoteTaintFlow
}
{
String trouble = intent.getExtras().getString("data");
sink(trouble); // $ hasRemoteTaintFlow
}
return -1;
}
@Override
public IBinder onBind(Intent intent) {
String trouble = intent.getStringExtra("data");
sink(trouble); // $ hasRemoteTaintFlow
{
String trouble = intent.getStringExtra("data");
sink(trouble); // $ hasRemoteTaintFlow
}
{
String trouble = intent.getExtras().getString("data");
sink(trouble); // $ hasRemoteTaintFlow
}
return null;
}
@Override
public boolean onUnbind(Intent intent) {
String trouble = intent.getStringExtra("data");
sink(trouble); // $ hasRemoteTaintFlow
{
String trouble = intent.getStringExtra("data");
sink(trouble); // $ hasRemoteTaintFlow
}
{
String trouble = intent.getExtras().getString("data");
sink(trouble); // $ hasRemoteTaintFlow
}
return false;
}
@Override
public void onRebind(Intent intent) {
String trouble = intent.getStringExtra("data");
sink(trouble); // $ hasRemoteTaintFlow
{
String trouble = intent.getStringExtra("data");
sink(trouble); // $ hasRemoteTaintFlow
}
{
String trouble = intent.getExtras().getString("data");
sink(trouble); // $ hasRemoteTaintFlow
}
}
@Override
public void onTaskRemoved(Intent intent) {
String trouble = intent.getStringExtra("data");
sink(trouble); // $ hasRemoteTaintFlow
{
String trouble = intent.getStringExtra("data");
sink(trouble); // $ hasRemoteTaintFlow
}
{
String trouble = intent.getExtras().getString("data");
sink(trouble); // $ hasRemoteTaintFlow
}
}
}