hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-01-30 06:42:57 +01:00
Code Issues Packages Projects Releases Wiki Activity

Use type to hint that constraining to embedded fields is a good first step

Browse Source 
This improves the join order for `implicitFieldSelection`
This commit is contained in:
Chris Smowton
2021-03-15 11:59:36 +00:00
committed by Owen Mansel-Chan
parent e1b4867a19
commit 22a3fccf79
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
ql/src/semmle/go/controlflow/ControlFlowGraphImpl.qll
View File

@@ -48,11 +48,15 @@ private predicate isCond(Expr e) {
e = any(ParenExpr par | isCond(par)).getExpr()
}
private class PromotedField extends Field {
PromotedField() { this = any(StructType t).getFieldOfEmbedded(_, _, _, _) }
}
private predicate implicitFieldSelection(SelectorExpr e, int i, Field implicitField) {
exists(StructType baseType, Field child |
exists(StructType baseType, PromotedField child |
baseType = e.getBase().getType().getBaseType*().getUnderlyingType() and
(
e.getSelector() = child.getAReference()
e.refersTo(child)
or
implicitFieldSelection(e, i + 1, child)
)