hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-18 01:33:15 +01:00
Code Issues Packages Projects Releases Wiki Activity

Update model for getAll

Browse Source
This commit is contained in:
Joe Farebrother
2021-08-10 15:05:02 +01:00
parent 227818adb4
commit 207c753f6f
2 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
java/ql/src/semmle/code/java/frameworks/guava/Cache.qll
View File

@@ -21,7 +21,7 @@ private class GuavaBaseCsv extends SummaryModelCsv {
"com.google.common.cache;LoadingCache;true;get;(Object);;MapValue of Argument[-1];ReturnValue;value",
"com.google.common.cache;LoadingCache;true;getUnchecked;(Object);;MapValue of Argument[-1];ReturnValue;value",
"com.google.common.cache;LoadingCache;true;apply;(Object);;MapValue of Argument[-1];ReturnValue;value",
"com.google.common.cache;LoadingCache;true;getAll;(Iterable);;Element of Argument[0];MapKey of ReturnValue;value",
"com.google.common.cache;LoadingCache;true;getAll;(Iterable);;MapKey of Argument[-1];MapKey of ReturnValue;value", // technically, an interestion between MapKey of Argument[-1] and Element of Argument[0]; but we don't model intersections.
"com.google.common.cache;LoadingCache;true;getAll;(Iterable);;MapValue of Argument[-1];MapValue of ReturnValue;value"
]
}

7
java/ql/test/library-tests/frameworks/guava/generated/cache/Test.java vendored
View File

@@ -139,11 +139,10 @@ public class Test {
sink(out); // $ hasValueFlow
}
{
// "com.google.common.cache;LoadingCache;true;getAll;(Iterable);;Element of Argument[0];MapKey of ReturnValue;value"
// "com.google.common.cache;LoadingCache;true;getAll;(Iterable);;MapKey of Argument[-1];MapKey of ReturnValue;value"
ImmutableMap out = null;
Iterable in = newWithElement(source());
LoadingCache instance = null;
out = instance.getAll(in);
LoadingCache in = newCacheWithMapKey(source());
out = in.getAll(null);
sink(getMapKey(out)); // $ hasValueFlow
}
{