hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-29 18:55:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

Python: Ignore functions with @property decorator for now

Browse Source
This commit is contained in:
Rasmus Wriedt Larsen
2022-10-14 11:38:45 +02:00
parent cba93ded77
commit 1e96ced3ab
2 changed files with 13 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
python/ql/lib/semmle/python/dataflow/new/internal/DataFlowDispatch.qll
View File

@@ -205,6 +205,13 @@ predicate isClassmethod(Function func) {
)
}
/** Holds if the function `func` has a `property` decorator. */
predicate hasPropertyDecorator(Function func) {
exists(NameNode id | id.getId() = "property" and id.isGlobal() |
func.getADecorator() = id.getNode()
)
}
// =============================================================================
// Callables
// =============================================================================
@@ -251,7 +258,11 @@ abstract class DataFlowCallable extends TDataFlowCallable {
abstract class DataFlowFunction extends DataFlowCallable, TFunction {
Function func;
DataFlowFunction() { this = TFunction(func) }
DataFlowFunction() {
this = TFunction(func) and
// TODO: Handle @property decorators
not hasPropertyDecorator(func)
}
override string toString() { result = func.toString() }

2
python/ql/test/experimental/library-tests/CallGraph/code/class_properties.py
View File

@@ -51,4 +51,4 @@ prop.arg2 = 43
del prop.arg2
f = prop.func_prop
f() # $ SPURIOUS: tt=Prop.func_prop MISSING: tt=func
f() # $ MISSING: tt=func