hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-26 01:05:15 +02:00
Code Issues Packages Projects Releases Wiki Activity

C#: Address review comments.

Browse Source
This commit is contained in:
Michael Nebel
2024-09-25 17:06:19 +02:00
parent af80797eda
commit 1dcc6ac2b1
2 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
csharp/ql/lib/semmle/code/csharp/security/dataflow/flowsinks/Html.qll
View File

@@ -61,6 +61,7 @@ class HtmlTextWriterSink extends HtmlSink {
deprecated class AttributeCollectionSink extends DataFlow::ExprNode {
AttributeCollectionSink() {
exists(SystemWebUIAttributeCollectionClass ac, Parameter p |
p = ac.getAddMethod().getParameter(1) or
p = ac.getItemProperty().getSetter().getParameter(0)
|
this.getExpr() = p.getAnAssignedArgument()

2
csharp/ql/src/change-notes/2024-09-25-attribute-collection-sink.md
View File

@@ -1,4 +1,4 @@
---
category: minorAnalysis
---
* C#: The indexer and `Add` method on `System.Web.UI.AttributeCollection` is no longer considered a HTML sink.
* C#: The indexer and `Add` method on `System.Web.UI.AttributeCollection` is no longer considered an HTML sink.