hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-01-30 06:42:57 +01:00
Code Issues Packages Projects Releases Wiki Activity

Improve variable names in example code

Browse Source 
These were inherited from the JS version of the example, which concerns HTML.
This commit is contained in:
Chris Smowton
2020-09-29 16:36:07 +01:00
parent 3dde501b54
commit 1cfad846c8
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
ql/src/Security/CWE-020/SuspiciousCharacterInRegexp.go
View File

@@ -3,8 +3,8 @@ package main
import "regexp"
func broken(hostNames []byte) string {
var htmlRe = regexp.MustCompile("\bforbidden.host.org")
if htmlRe.Match(hostNames) {
var hostRe = regexp.MustCompile("\bforbidden.host.org")
if hostRe.Match(hostNames) {
return "Must not target forbidden.host.org"
} else {
// This will be reached even if hostNames is exactly "forbidden.host.org",

4
ql/src/Security/CWE-020/SuspiciousCharacterInRegexpGood.go
View File

@@ -3,8 +3,8 @@ package main
import "regexp"
func fixed(hostNames []byte) string {
var htmlRe = regexp.MustCompile("\\bforbidden.host.org")
if htmlRe.Match(hostNames) {
var hostRe = regexp.MustCompile("\\bforbidden.host.org")
if hostRe.Match(hostNames) {
return "Must not target forbidden.host.org"
} else {
// hostNames definitely doesn't contain a word "forbidden.host.org", as "\\b"