hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-01-30 23:02:56 +01:00
Code Issues Packages Projects Releases Wiki Activity

Expose receiver type in isInterfaceCallReceiver.

Browse Source
This commit is contained in:
Max Schaefer
2020-06-19 11:35:49 +01:00
parent 0e5e116217
commit 1c58028ae3
1 changed files with 8 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
ql/src/semmle/go/dataflow/internal/DataFlowDispatch.qll
View File

@@ -2,18 +2,20 @@ private import go
private import DataFlowPrivate
/**
* Holds if `call` is an interface call to method `m`, meaning that its receiver `recv` has an
* interface type.
* Holds if `call` is an interface call to method `m`, meaning that its receiver `recv` has
* interface type `tp`.
*/
private predicate isInterfaceCallReceiver(DataFlow::CallNode call, DataFlow::Node recv, string m) {
private predicate isInterfaceCallReceiver(
DataFlow::CallNode call, DataFlow::Node recv, InterfaceType tp, string m
) {
call.getReceiver() = recv and
recv.getType().getUnderlyingType() instanceof InterfaceType and
recv.getType().getUnderlyingType() = tp and
m = call.getCalleeName()
}
/** Gets a data-flow node that may flow into the receiver value of `call`, which is an interface value. */
private DataFlow::Node getInterfaceCallReceiverSource(DataFlow::CallNode call) {
isInterfaceCallReceiver(call, result.getASuccessor*(), _)
isInterfaceCallReceiver(call, result.getASuccessor*(), _, _)
}
/** Gets the type of `nd`, which must be a valid type and not an interface type. */
@@ -44,7 +46,7 @@ private predicate isConcreteValue(DataFlow::Node nd) {
* types of `recv` can be established by local reasoning.
*/
private predicate isConcreteInterfaceCall(DataFlow::Node call, DataFlow::Node recv, string m) {
isInterfaceCallReceiver(call, recv, m) and isConcreteValue(recv)
isInterfaceCallReceiver(call, recv, _, m) and isConcreteValue(recv)
}
/**