C#: Add queries medium precision queries to the code-quality-extended suite (and update tags).

2025-12-16 16:53:25 +01:00 · 2025-09-05 13:01:33 +02:00
parent 6d9e489e7c
commit 17735a9a43
42 changed files with 118 additions and 76 deletions
--- a/Abuse/ClassDoesNotImplementEquals.ql
+++ b/Abuse/ClassDoesNotImplementEquals.ql
@@ -7,8 +7,9 @@
 * @problem.severity error
 * @precision medium
 * @id cs/class-missing-equals
- * @tags reliability
- *       maintainability
+ * @tags quality
+ *       reliability
+ *       correctness
 */

 import csharp
--- a/Abuse/DisposeNotCalledOnException.ql
+++ b/Abuse/DisposeNotCalledOnException.ql
@@ -7,8 +7,10 @@
 * @problem.severity warning
 * @precision medium
 * @id cs/dispose-not-called-on-throw
- * @tags efficiency
- *       maintainability
+ * @tags quality
+ *       reliability
+ *       error-handling
+ *       performance
 *       external/cwe/cwe-404
 *       external/cwe/cwe-459
 *       external/cwe/cwe-460
--- a/Abuse/InconsistentEqualsGetHashCode.ql
+++ b/Abuse/InconsistentEqualsGetHashCode.ql
@@ -6,8 +6,9 @@
 * @problem.severity warning
 * @precision medium
 * @id cs/inconsistent-equals-and-gethashcode
- * @tags reliability
- *       maintainability
+ * @tags quality
+ *       reliability
+ *       correctness
 *       external/cwe/cwe-581
 */

--- a/Abuse/IncorrectCompareToSignature.ql
+++ b/Abuse/IncorrectCompareToSignature.ql
@@ -5,8 +5,9 @@
 * @problem.severity warning
 * @precision medium
 * @id cs/wrong-compareto-signature
- * @tags reliability
- *       maintainability
+ * @tags quality
+ *       reliability
+ *       correctness
 */

 import csharp
--- a/Abuse/IncorrectEqualsSignature.ql
+++ b/Abuse/IncorrectEqualsSignature.ql
@@ -5,7 +5,8 @@
 * @problem.severity warning
 * @precision medium
 * @id cs/wrong-equals-signature
- * @tags reliability
+ * @tags quality
+ *       reliability
 *       maintainability
 */

--- a/Abuse/NonOverridingMethod.ql
+++ b/Abuse/NonOverridingMethod.ql
@@ -5,9 +5,10 @@
 * @problem.severity recommendation
 * @precision medium
 * @id cs/nonoverriding-method
- * @tags reliability
+ * @tags quality
+ *       reliability
+ *       correctness
 *       readability
- *       naming
 */

 import csharp
--- a/csharp/ql/src/ASP/SplitControlStructure.ql
+++ b/csharp/ql/src/ASP/SplitControlStructure.ql
@@ -5,8 +5,9 @@
 * @problem.severity recommendation
 * @precision medium
 * @id cs/asp/split-control-structure
- * @tags maintainability
- *       frameworks/asp.net
+ * @tags quality
+ *       maintainability
+ *       readability
 */

 import semmle.code.asp.AspNet
--- a/Practices/Comments/CommentedOutCode.ql
+++ b/Practices/Comments/CommentedOutCode.ql
@@ -5,9 +5,9 @@
 * @problem.severity recommendation
 * @precision medium
 * @id cs/commented-out-code
- * @tags maintainability
- *       statistical
- *       non-attributable
+ * @tags quality
+ *       maintainability
+ *       readability
 */

 import csharp
--- a/Practices/Comments/TodoComments.ql
+++ b/Practices/Comments/TodoComments.ql
@@ -6,7 +6,8 @@
 * @problem.severity recommendation
 * @precision medium
 * @id cs/todo-comment
- * @tags maintainability
+ * @tags quality
+ *       maintainability
 *       external/cwe/cwe-546
 */

--- a/Practices/Declarations/NoConstantsOnly.ql
+++ b/Practices/Declarations/NoConstantsOnly.ql
@@ -6,8 +6,9 @@
 * @problem.severity recommendation
 * @precision medium
 * @id cs/constants-only-interface
- * @tags maintainability
- *       modularity
+ * @tags quality
+ *       maintainability
+ *       readability
 */

 import csharp
--- a/Practices/ErroneousClassCompare.ql
+++ b/Practices/ErroneousClassCompare.ql
@@ -5,7 +5,8 @@
 * @problem.severity warning
 * @precision medium
 * @id cs/class-name-comparison
- * @tags reliability
+ * @tags quality
+ *       reliability
 *       correctness
 *       external/cwe/cwe-486
 */
--- a/Hiding/AbstractToConcreteCollection.ql
+++ b/Hiding/AbstractToConcreteCollection.ql
@@ -7,9 +7,9 @@
 * @problem.severity warning
 * @precision medium
 * @id cs/cast-from-abstract-to-concrete-collection
- * @tags reliability
- *       maintainability
- *       modularity
+ * @tags quality
+ *       reliability
+ *       correctness
 *       external/cwe/cwe-485
 */

--- a/Practices/Implementation
+++ b/Practices/Implementation
@@ -5,9 +5,9 @@
 * @problem.severity recommendation
 * @precision medium
 * @id cs/static-array
- * @tags reliability
- *       maintainability
- *       modularity
+ * @tags quality
+ *       reliability
+ *       correctness
 *       external/cwe/cwe-582
 */

--- a/Conventions/ConfusingMethodNames.ql
+++ b/Conventions/ConfusingMethodNames.ql
@@ -5,9 +5,9 @@
 * @problem.severity recommendation
 * @precision medium
 * @id cs/confusing-method-name
- * @tags maintainability
+ * @tags quality
+ *       maintainability
 *       readability
- *       naming
 */

 import csharp
--- a/Conventions/ConfusingOverridesNames.ql
+++ b/Conventions/ConfusingOverridesNames.ql
@@ -6,9 +6,10 @@
 * @problem.severity recommendation
 * @precision medium
 * @id cs/confusing-override-name
- * @tags reliability
+ * @tags quality
+ *       maintainability
 *       readability
- *       naming
+ *       correctness
 */

 import csharp
--- a/Conventions/ControlNamePrefixes.ql
+++ b/Conventions/ControlNamePrefixes.ql
@@ -6,7 +6,9 @@
 * @problem.severity recommendation
 * @precision medium
 * @id cs/web/unprefixed-control-name
- * @tags maintainability
+ * @tags quality
+ *       maintainability
+ *       readability
 */

 import csharp
--- a/Conventions/DefaultControlNames.ql
+++ b/Conventions/DefaultControlNames.ql
@@ -6,8 +6,9 @@
 * @problem.severity recommendation
 * @precision medium
 * @id cs/forms/default-control-name
- * @tags readability
- *       naming
+ * @tags quality
+ *       maintainability
+ *       readability
 */

 import csharp
--- a/Practices/UseOfSystemOutputStream.ql
+++ b/Practices/UseOfSystemOutputStream.ql
@@ -5,7 +5,9 @@
 * @problem.severity recommendation
 * @precision medium
 * @id cs/console-output
- * @tags maintainability
+ * @tags quality
+ *       reliability
+ *       error-handling
 */

 import csharp
--- a/Practices/VirtualCallInConstructorOrDestructor.ql
+++ b/Practices/VirtualCallInConstructorOrDestructor.ql
@@ -6,9 +6,9 @@
 * @precision medium
 * @id cs/virtual-call-in-constructor
 * @alternate-ids cs/virtual-call-in-constructor-or-destructor
- * @tags reliability
- *       maintainability
- *       modularity
+ * @tags quality
+ *       reliability
+ *       correctness
 */

 import csharp
--- a/csharp/ql/src/Concurrency/SynchSetUnsynchGet.ql
+++ b/csharp/ql/src/Concurrency/SynchSetUnsynchGet.ql
@@ -6,8 +6,10 @@
 * @problem.severity error
 * @precision medium
 * @id cs/unsynchronized-getter
- * @tags correctness
+ * @tags quality
+ *       reliability
 *       concurrency
+ *       correctness
 *       external/cwe/cwe-662
 */

--- a/csharp/ql/src/Concurrency/UnsafeLazyInitialization.ql
+++ b/csharp/ql/src/Concurrency/UnsafeLazyInitialization.ql
@@ -6,7 +6,8 @@
 * @problem.severity error
 * @precision medium
 * @id cs/unsafe-double-checked-lock
- * @tags correctness
+ * @tags quality
+ *       reliability
 *       concurrency
 *       external/cwe/cwe-609
 */
--- a/csharp/ql/src/Concurrency/UnsynchronizedStaticAccess.ql
+++ b/csharp/ql/src/Concurrency/UnsynchronizedStaticAccess.ql
@@ -6,7 +6,9 @@
 * @problem.severity error
 * @precision medium
 * @id cs/unsynchronized-static-access
- * @tags concurrency
+ * @tags quality
+ *       reliability
+ *       concurrency
 *       external/cwe/cwe-362
 *       external/cwe/cwe-567
 */
--- a/csharp/ql/src/Documentation/XmldocExtraParam.ql
+++ b/csharp/ql/src/Documentation/XmldocExtraParam.ql
@@ -6,7 +6,9 @@
 * @problem.severity recommendation
 * @precision medium
 * @id cs/xmldoc/unknown-parameter
- * @tags maintainability
+ * @tags quality
+ *       maintainability
+ *       readability
 */

 import Documentation
--- a/csharp/ql/src/Documentation/XmldocExtraTypeParam.ql
+++ b/csharp/ql/src/Documentation/XmldocExtraTypeParam.ql
@@ -6,7 +6,9 @@
 * @problem.severity recommendation
 * @precision medium
 * @id cs/xmldoc/unknown-type-parameter
- * @tags maintainability
+ * @tags quality
+ *       maintainability
+ *       readability
 */

 import Documentation
--- a/csharp/ql/src/Documentation/XmldocMissing.ql
+++ b/csharp/ql/src/Documentation/XmldocMissing.ql
@@ -6,7 +6,9 @@
 * @problem.severity recommendation
 * @precision medium
 * @id cs/xmldoc/missing-xmldoc
- * @tags maintainability
+ * @tags quality
+ *       maintainability
+ *       readability
 */

 import Documentation
--- a/Abuse/ForeachCapture.ql
+++ b/Abuse/ForeachCapture.ql
@@ -7,9 +7,9 @@
 * @problem.severity recommendation
 * @precision medium
 * @id cs/captured-foreach-variable
- * @tags portability
- *       maintainability
- *       language-features
+ * @tags quality
+ *       reliability
+ *       correctness
 *       external/cwe/cwe-758
 */

--- a/Abuse/UselessCastToSelf.ql
+++ b/Abuse/UselessCastToSelf.ql
@@ -5,8 +5,9 @@
 * @problem.severity warning
 * @precision medium
 * @id cs/useless-cast-to-self
- * @tags maintainability
- *       language-features
+ * @tags quality
+ *       maintainability
+ *       useless-code
 *       external/cwe/cwe-561
 */

--- a/Abuse/UselessIsBeforeAs.ql
+++ b/Abuse/UselessIsBeforeAs.ql
@@ -5,8 +5,9 @@
 * @problem.severity recommendation
 * @precision medium
 * @id cs/useless-is-before-as
- * @tags maintainability
- *       language-features
+ * @tags quality
+ *       maintainability
+ *       useless-code
 *       external/cwe/cwe-561
 */

--- a/Abuse/UselessNullCoalescingExpression.ql
+++ b/Abuse/UselessNullCoalescingExpression.ql
@@ -6,8 +6,9 @@
 * @problem.severity error
 * @precision medium
 * @id cs/coalesce-of-identical-expressions
- * @tags maintainability
- *       language-features
+ * @tags quality
+ *       maintainability
+ *       useless-code
 *       external/cwe/cwe-561
 */

--- a/Abuse/UselessTypeTest.ql
+++ b/Abuse/UselessTypeTest.ql
@@ -5,8 +5,9 @@
 * @problem.severity warning
 * @precision medium
 * @id cs/useless-type-test
- * @tags maintainability
- *       language-features
+ * @tags quality
+ *       maintainability
+ *       useless-code
 *       external/cwe/cwe-561
 */

--- a/Abuse/UselessUpcast.ql
+++ b/Abuse/UselessUpcast.ql
@@ -5,8 +5,9 @@
 * @problem.severity warning
 * @precision medium
 * @id cs/useless-upcast
- * @tags maintainability
- *       language-features
+ * @tags quality
+ *       maintainability
+ *       useless-code
 *       external/cwe/cwe-561
 */

--- a/Bugs/Dynamic/BadDynamicCall.ql
+++ b/Bugs/Dynamic/BadDynamicCall.ql
@@ -5,9 +5,9 @@
 * @problem.severity error
 * @precision medium
 * @id cs/invalid-dynamic-call
- * @tags reliability
+ * @tags quality
+ *       reliability
 *       correctness
- *       logic
 *       external/cwe/cwe-628
 */

--- a/Bugs/EqualsUsesAs.ql
+++ b/Bugs/EqualsUsesAs.ql
@@ -5,8 +5,9 @@
 * @problem.severity warning
 * @precision medium
 * @id cs/equals-uses-as
- * @tags reliability
- *       maintainability
+ * @tags quality
+ *       reliability
+ *       correctness
 */

 import csharp
--- a/Bugs/EqualsUsesIs.ql
+++ b/Bugs/EqualsUsesIs.ql
@@ -5,8 +5,9 @@
 * @problem.severity warning
 * @precision medium
 * @id cs/equals-uses-is
- * @tags reliability
- *       maintainability
+ * @tags quality
+ *       reliability
+ *       correctness
 */

 import csharp
--- a/Bugs/InconsistentCompareTo.ql
+++ b/Bugs/InconsistentCompareTo.ql
@@ -5,8 +5,9 @@
 * @problem.severity warning
 * @precision medium
 * @id cs/inconsistent-compareto-and-equals
- * @tags reliability
- *       maintainability
+ * @tags quality
+ *       reliability
+ *       correctness
 */

 import semmle.code.csharp.frameworks.System
--- a/Bugs/LeapYear/UnsafeYearConstruction.ql
+++ b/Bugs/LeapYear/UnsafeYearConstruction.ql
@@ -5,8 +5,9 @@
 * @problem.severity warning
 * @precision medium
 * @id cs/unsafe-year-construction
- * @tags date-time
+ * @tags quality
 *       reliability
+ *       correctness
 */

 import csharp
--- a/Bugs/MishandlingJapaneseEra.ql
+++ b/Bugs/MishandlingJapaneseEra.ql
@@ -5,8 +5,9 @@
 * @kind problem
 * @problem.severity warning
 * @precision medium
- * @tags reliability
- *       date-time
+ * @tags quality
+ *       reliability
+ *       correctness
 */

 import csharp
--- a/Bugs/ObjectComparison.ql
+++ b/Bugs/ObjectComparison.ql
@@ -6,7 +6,8 @@
 * @problem.severity warning
 * @precision medium
 * @id cs/reference-equality-with-object
- * @tags reliability
+ * @tags quality
+ *       reliability
 *       correctness
 *       external/cwe/cwe-595
 */
--- a/Bugs/RecursiveOperatorEquals.ql
+++ b/Bugs/RecursiveOperatorEquals.ql
@@ -5,8 +5,9 @@
 * @problem.severity error
 * @precision medium
 * @id cs/recursive-operator-equals-call
- * @tags reliability
- *       maintainability
+ * @tags quality
+ *       reliability
+ *       correctness
 */

 import csharp
--- a/Bugs/Statements/UseBraces.ql
+++ b/Bugs/Statements/UseBraces.ql
@@ -6,9 +6,10 @@
 * @problem.severity warning
 * @precision medium
 * @id cs/misleading-indentation
- * @tags changeability
+ * @tags quality
+ *       maintainability
+ *       readability
 *       correctness
- *       logic
 */

 import csharp
--- a/csharp/ql/src/Linq/BadMultipleIteration.ql
+++ b/csharp/ql/src/Linq/BadMultipleIteration.ql
@@ -5,9 +5,9 @@
 * @problem.severity warning
 * @precision medium
 * @id cs/linq/inconsistent-enumeration
- * @tags reliability
- *       maintainability
- *       language-features
+ * @tags quality
+ *       reliability
+ *       correctness
 *       external/cwe/cwe-834
 */

--- a/code/PointlessForwardingMethod.ql
+++ b/code/PointlessForwardingMethod.ql
@@ -5,7 +5,8 @@
 * @problem.severity recommendation
 * @precision medium
 * @id cs/useless-forwarding-method
- * @tags maintainability
+ * @tags quality
+ *       maintainability
 *       useless-code
 */