hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-22 23:35:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

C#: Include normal switch/case statements in the white list and allow the use of wildcards when there is a condition.

Browse Source
This commit is contained in:
Michael Nebel
2025-03-11 14:37:56 +01:00
parent c15137e992
commit 150aa5d1cf
1 changed files with 8 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
csharp/ql/src/Bad Practices/Control-Flow/ConstantCondition.ql
View File

@@ -119,9 +119,14 @@ class ConstantMatchingCondition extends ConstantCondition {
}
override predicate isWhiteListed() {
exists(SwitchExpr se, int i |
se.getCase(i).getPattern() = this.(DiscardExpr) and
i > 0
exists(Switch se, Case c, int i | c = se.getCase(i) |
c.getPattern() = this.(DiscardExpr) and
(
i > 0
or
i = 0 and
exists(Expr cond | c.getCondition() = cond and not isConstantCondition(cond, true))
)
)
or
this = any(PositionalPatternExpr ppe).getPattern(_)