hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-16 16:53:25 +01:00
Code Issues Packages Projects Releases Wiki Activity

move the consistency predicates where they should be

Browse Source
This commit is contained in:
Erik Krogh Kristensen
2022-06-16 09:13:09 +02:00
parent 4be969ca3b
commit 14b5f8410f
2 changed files with 10 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
ql/ql/src/codeql_ql/ast/internal/Module.qll
View File

@@ -311,4 +311,8 @@ module ModConsistency {
c > 1 and
resolveModuleExpr(me, m)
}
query predicate noName(Module mod) { not exists(mod.getName()) }
query predicate nonUniqueName(Module mod) { count(mod.getName()) >= 2 }
}

15
ql/ql/src/queries/diagnostics/EmptyConsistencies.ql
View File

@@ -31,7 +31,7 @@ where
TypeConsistency::multiplePrimitivesExpr(node, _, _) and
msg = "TypeConsistency::multiplePrimitivesExpr"
or
AstConsistency::nonTotalGetParent(node) and msg = "AstConsistency::nonTotalGetParent"
AstConsistency::nonTotalGetParent(node) and msg = "AstConsistency::nonTotalGetParent" // TODO: unique parent
or
TypeConsistency::noResolve(node) and msg = "TypeConsistency::noResolve"
or
@@ -39,15 +39,12 @@ where
or
ModConsistency::noResolveModuleExpr(node) and msg = "ModConsistency::noResolveModuleExpr"
or
ModConsistency::noName(node) and msg = "ModConsistency::noName"
or
ModConsistency::nonUniqueName(node) and msg = "ModConsistency::nonUniqueName"
or
VarConsistency::noFieldDef(node) and msg = "VarConsistency::noFieldDef"
or
VarConsistency::noVarDef(node) and msg = "VarConsistency::noVarDef"
or
node instanceof ModuleExpr and
not exists(node.(ModuleExpr).getName()) and
msg = "exists(ModuleExpr::getName)"
or
node instanceof ModuleExpr and
count(node.(ModuleExpr).getName()) >= 2 and
msg = "unique(ModuleExpr::getName)"
select node, msg
// TODO: vardef consistency.