hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-19 22:14:01 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #18831 from owen-mc/go/join-order-fix-2

Browse Source 
Go: Improve bad join order in guardingCall
This commit is contained in:
Owen Mansel-Chan
2025-02-24 22:16:22 +00:00
committed by GitHub
parent 6437bd692e d9d909a61e
commit 0d994c1527
1 changed files with 10 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
go/ql/lib/semmle/go/dataflow/internal/DataFlowUtil.qll
View File

@@ -379,6 +379,14 @@ module BarrierGuard<guardChecksSig/3 guardChecks> {
)
}
bindingset[inp, c]
pragma[inline_late]
private Node getInputNode(FunctionInput inp, CallNode c) { result = inp.getNode(c) }
bindingset[outp, c]
pragma[inline_late]
private Node getOutputNode(FunctionOutput outp, CallNode c) { result = outp.getNode(c) }
pragma[noinline]
private predicate guardingCall(
Node g, Function f, FunctionInput inp, FunctionOutput outp, DataFlow::Property p, CallNode c,
@@ -386,8 +394,8 @@ module BarrierGuard<guardChecksSig/3 guardChecks> {
) {
guardingFunction(g, f, inp, outp, p) and
c = f.getACall() and
nd = inp.getNode(c) and
localFlow(pragma[only_bind_out](outp.getNode(c)), resNode)
nd = getInputNode(inp, c) and
localFlow(getOutputNode(outp, c), resNode)
}
private predicate onlyPossibleReturnSatisfyingProperty(