Merge pull request #7273 from github/ruby/crypto-algorithms

Ruby: add CryptoAlgorithms library
This commit is contained in:
Alex Ford
2021-12-22 17:42:59 +00:00
committed by GitHub
13 changed files with 1021 additions and 96 deletions

View File

@@ -452,9 +452,15 @@
"ruby/ql/lib/codeql/ruby/dataflow/internal/SsaImplCommon.qll",
"cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/SsaImplCommon.qll"
],
"CryptoAlgorithms Python/JS": [
"CryptoAlgorithms Python/JS/Ruby": [
"javascript/ql/lib/semmle/javascript/security/CryptoAlgorithms.qll",
"python/ql/lib/semmle/python/concepts/CryptoAlgorithms.qll"
"python/ql/lib/semmle/python/concepts/CryptoAlgorithms.qll",
"ruby/ql/lib/codeql/ruby/security/CryptoAlgorithms.qll"
],
"CryptoAlgorithmNames Python/JS/Ruby": [
"javascript/ql/lib/semmle/javascript/security/internal/CryptoAlgorithmNames.qll",
"python/ql/lib/semmle/python/concepts/internal/CryptoAlgorithmNames.qll",
"ruby/ql/lib/codeql/ruby/security/internal/CryptoAlgorithmNames.qll"
],
"SensitiveDataHeuristics Python/JS": [
"javascript/ql/lib/semmle/javascript/security/internal/SensitiveDataHeuristics.qll",

View File

@@ -1,55 +1,10 @@
/**
* Provides classes modeling cryptographic algorithms, separated into strong and weak variants.
*
* The classification into strong and weak are based on Wikipedia, OWASP and google (2017).
* The classification into strong and weak are based on Wikipedia, OWASP and Google (2021).
*/
/**
* Names of cryptographic algorithms, separated into strong and weak variants.
*
* The names are normalized: upper-case, no spaces, dashes or underscores.
*
* The names are inspired by the names used in real world crypto libraries.
*
* The classification into strong and weak are based on Wikipedia, OWASP and google (2017).
*/
private module AlgorithmNames {
predicate isStrongHashingAlgorithm(string name) {
name =
[
"DSA", "ED25519", "ES256", "ECDSA256", "ES384", "ECDSA384", "ES512", "ECDSA512", "SHA2",
"SHA224", "SHA256", "SHA384", "SHA512", "SHA3", "SHA3224", "SHA3256", "SHA3384", "SHA3512"
]
}
predicate isWeakHashingAlgorithm(string name) {
name =
[
"HAVEL128", "MD2", "MD4", "MD5", "PANAMA", "RIPEMD", "RIPEMD128", "RIPEMD256", "RIPEMD160",
"RIPEMD320", "SHA0", "SHA1"
]
}
predicate isStrongEncryptionAlgorithm(string name) {
name = ["AES", "AES128", "AES192", "AES256", "AES512", "RSA", "RABBIT", "BLOWFISH"]
}
predicate isWeakEncryptionAlgorithm(string name) {
name =
[
"DES", "3DES", "TRIPLEDES", "TDEA", "TRIPLEDEA", "ARC2", "RC2", "ARC4", "RC4", "ARCFOUR",
"ARC5", "RC5"
]
}
predicate isStrongPasswordHashingAlgorithm(string name) {
name = ["ARGON2", "PBKDF2", "BCRYPT", "SCRYPT"]
}
predicate isWeakPasswordHashingAlgorithm(string name) { name = "EVPKDF" }
}
private import AlgorithmNames
private import internal.CryptoAlgorithmNames
/**
* A cryptographic algorithm.

View File

@@ -0,0 +1,72 @@
/**
* Names of cryptographic algorithms, separated into strong and weak variants.
*
* The names are normalized: upper-case, no spaces, dashes or underscores.
*
* The names are inspired by the names used in real world crypto libraries.
*
* The classification into strong and weak are based on Wikipedia, OWASP and Google (2021).
*/
/**
* Holds if `name` corresponds to a strong hashing algorithm.
*/
predicate isStrongHashingAlgorithm(string name) {
name =
[
"DSA", "ED25519", "ES256", "ECDSA256", "ES384", "ECDSA384", "ES512", "ECDSA512", "SHA2",
"SHA224", "SHA256", "SHA384", "SHA512", "SHA3", "SHA3224", "SHA3256", "SHA3384", "SHA3512"
]
}
/**
* Holds if `name` corresponds to a weak hashing algorithm.
*/
predicate isWeakHashingAlgorithm(string name) {
name =
[
"HAVEL128", "MD2", "MD4", "MD5", "PANAMA", "RIPEMD", "RIPEMD128", "RIPEMD256", "RIPEMD160",
"RIPEMD320", "SHA0", "SHA1"
]
}
/**
* Holds if `name` corresponds to a strong encryption algorithm.
*/
predicate isStrongEncryptionAlgorithm(string name) {
name =
[
"AES", "AES128", "AES192", "AES256", "AES512", "AES-128", "AES-192", "AES-256", "AES-512",
"ARIA", "BLOWFISH", "BF", "ECIES", "CAST", "CAST5", "CAMELLIA", "CAMELLIA128", "CAMELLIA192",
"CAMELLIA256", "CAMELLIA-128", "CAMELLIA-192", "CAMELLIA-256", "CHACHA", "GOST", "GOST89",
"IDEA", "RABBIT", "RSA", "SEED", "SM4"
]
}
/**
* Holds if `name` corresponds to a weak encryption algorithm.
*/
predicate isWeakEncryptionAlgorithm(string name) {
name =
[
"DES", "3DES", "DES3", "TRIPLEDES", "DESX", "TDEA", "TRIPLEDEA", "ARC2", "RC2", "ARC4", "RC4",
"ARCFOUR", "ARC5", "RC5"
]
}
/**
* Holds if `name` corresponds to a strong password hashing algorithm.
*/
predicate isStrongPasswordHashingAlgorithm(string name) {
name = ["ARGON2", "PBKDF2", "BCRYPT", "SCRYPT"]
}
/**
* Holds if `name` corresponds to a weak password hashing algorithm.
*/
predicate isWeakPasswordHashingAlgorithm(string name) { name = "EVPKDF" }
/**
* Holds if `name` corresponds to a weak block cipher mode of operation.
*/
predicate isWeakBlockMode(string name) { name = "ECB" }

View File

@@ -1,55 +1,10 @@
/**
* Provides classes modeling cryptographic algorithms, separated into strong and weak variants.
*
* The classification into strong and weak are based on Wikipedia, OWASP and google (2017).
* The classification into strong and weak are based on Wikipedia, OWASP and Google (2021).
*/
/**
* Names of cryptographic algorithms, separated into strong and weak variants.
*
* The names are normalized: upper-case, no spaces, dashes or underscores.
*
* The names are inspired by the names used in real world crypto libraries.
*
* The classification into strong and weak are based on Wikipedia, OWASP and google (2017).
*/
private module AlgorithmNames {
predicate isStrongHashingAlgorithm(string name) {
name =
[
"DSA", "ED25519", "ES256", "ECDSA256", "ES384", "ECDSA384", "ES512", "ECDSA512", "SHA2",
"SHA224", "SHA256", "SHA384", "SHA512", "SHA3", "SHA3224", "SHA3256", "SHA3384", "SHA3512"
]
}
predicate isWeakHashingAlgorithm(string name) {
name =
[
"HAVEL128", "MD2", "MD4", "MD5", "PANAMA", "RIPEMD", "RIPEMD128", "RIPEMD256", "RIPEMD160",
"RIPEMD320", "SHA0", "SHA1"
]
}
predicate isStrongEncryptionAlgorithm(string name) {
name = ["AES", "AES128", "AES192", "AES256", "AES512", "RSA", "RABBIT", "BLOWFISH"]
}
predicate isWeakEncryptionAlgorithm(string name) {
name =
[
"DES", "3DES", "TRIPLEDES", "TDEA", "TRIPLEDEA", "ARC2", "RC2", "ARC4", "RC4", "ARCFOUR",
"ARC5", "RC5"
]
}
predicate isStrongPasswordHashingAlgorithm(string name) {
name = ["ARGON2", "PBKDF2", "BCRYPT", "SCRYPT"]
}
predicate isWeakPasswordHashingAlgorithm(string name) { name = "EVPKDF" }
}
private import AlgorithmNames
private import internal.CryptoAlgorithmNames
/**
* A cryptographic algorithm.

View File

@@ -0,0 +1,72 @@
/**
* Names of cryptographic algorithms, separated into strong and weak variants.
*
* The names are normalized: upper-case, no spaces, dashes or underscores.
*
* The names are inspired by the names used in real world crypto libraries.
*
* The classification into strong and weak are based on Wikipedia, OWASP and Google (2021).
*/
/**
* Holds if `name` corresponds to a strong hashing algorithm.
*/
predicate isStrongHashingAlgorithm(string name) {
name =
[
"DSA", "ED25519", "ES256", "ECDSA256", "ES384", "ECDSA384", "ES512", "ECDSA512", "SHA2",
"SHA224", "SHA256", "SHA384", "SHA512", "SHA3", "SHA3224", "SHA3256", "SHA3384", "SHA3512"
]
}
/**
* Holds if `name` corresponds to a weak hashing algorithm.
*/
predicate isWeakHashingAlgorithm(string name) {
name =
[
"HAVEL128", "MD2", "MD4", "MD5", "PANAMA", "RIPEMD", "RIPEMD128", "RIPEMD256", "RIPEMD160",
"RIPEMD320", "SHA0", "SHA1"
]
}
/**
* Holds if `name` corresponds to a strong encryption algorithm.
*/
predicate isStrongEncryptionAlgorithm(string name) {
name =
[
"AES", "AES128", "AES192", "AES256", "AES512", "AES-128", "AES-192", "AES-256", "AES-512",
"ARIA", "BLOWFISH", "BF", "ECIES", "CAST", "CAST5", "CAMELLIA", "CAMELLIA128", "CAMELLIA192",
"CAMELLIA256", "CAMELLIA-128", "CAMELLIA-192", "CAMELLIA-256", "CHACHA", "GOST", "GOST89",
"IDEA", "RABBIT", "RSA", "SEED", "SM4"
]
}
/**
* Holds if `name` corresponds to a weak encryption algorithm.
*/
predicate isWeakEncryptionAlgorithm(string name) {
name =
[
"DES", "3DES", "DES3", "TRIPLEDES", "DESX", "TDEA", "TRIPLEDEA", "ARC2", "RC2", "ARC4", "RC4",
"ARCFOUR", "ARC5", "RC5"
]
}
/**
* Holds if `name` corresponds to a strong password hashing algorithm.
*/
predicate isStrongPasswordHashingAlgorithm(string name) {
name = ["ARGON2", "PBKDF2", "BCRYPT", "SCRYPT"]
}
/**
* Holds if `name` corresponds to a weak password hashing algorithm.
*/
predicate isWeakPasswordHashingAlgorithm(string name) { name = "EVPKDF" }
/**
* Holds if `name` corresponds to a weak block cipher mode of operation.
*/
predicate isWeakBlockMode(string name) { name = "ECB" }

View File

@@ -0,0 +1,98 @@
/**
* Provides classes modeling cryptographic algorithms, separated into strong and weak variants.
*
* The classification into strong and weak are based on Wikipedia, OWASP and Google (2021).
*/
private import internal.CryptoAlgorithmNames
/**
* A cryptographic algorithm.
*/
private newtype TCryptographicAlgorithm =
MkHashingAlgorithm(string name, boolean isWeak) {
isStrongHashingAlgorithm(name) and isWeak = false
or
isWeakHashingAlgorithm(name) and isWeak = true
} or
MkEncryptionAlgorithm(string name, boolean isWeak) {
isStrongEncryptionAlgorithm(name) and isWeak = false
or
isWeakEncryptionAlgorithm(name) and isWeak = true
} or
MkPasswordHashingAlgorithm(string name, boolean isWeak) {
isStrongPasswordHashingAlgorithm(name) and isWeak = false
or
isWeakPasswordHashingAlgorithm(name) and isWeak = true
}
/**
* A cryptographic algorithm.
*/
abstract class CryptographicAlgorithm extends TCryptographicAlgorithm {
/** Gets a textual representation of this element. */
string toString() { result = getName() }
/**
* Gets the normalized name of this algorithm (upper-case, no spaces, dashes or underscores).
*/
abstract string getName();
/**
* Holds if the name of this algorithm matches `name` modulo case,
* white space, dashes, underscores, and anything after a dash in the name
* (to ignore modes of operation, such as CBC or ECB).
*/
bindingset[name]
predicate matchesName(string name) {
[name.toUpperCase(), name.toUpperCase().regexpCapture("^(\\w+)(?:-.*)?$", 1)]
.regexpReplaceAll("[-_ ]", "") = getName()
}
/**
* Holds if this algorithm is weak.
*/
abstract predicate isWeak();
}
/**
* A hashing algorithm such as `MD5` or `SHA512`.
*/
class HashingAlgorithm extends MkHashingAlgorithm, CryptographicAlgorithm {
string name;
boolean isWeak;
HashingAlgorithm() { this = MkHashingAlgorithm(name, isWeak) }
override string getName() { result = name }
override predicate isWeak() { isWeak = true }
}
/**
* An encryption algorithm such as `DES` or `AES512`.
*/
class EncryptionAlgorithm extends MkEncryptionAlgorithm, CryptographicAlgorithm {
string name;
boolean isWeak;
EncryptionAlgorithm() { this = MkEncryptionAlgorithm(name, isWeak) }
override string getName() { result = name }
override predicate isWeak() { isWeak = true }
}
/**
* A password hashing algorithm such as `PBKDF2` or `SCRYPT`.
*/
class PasswordHashingAlgorithm extends MkPasswordHashingAlgorithm, CryptographicAlgorithm {
string name;
boolean isWeak;
PasswordHashingAlgorithm() { this = MkPasswordHashingAlgorithm(name, isWeak) }
override string getName() { result = name }
override predicate isWeak() { isWeak = true }
}

View File

@@ -0,0 +1,311 @@
/**
* Provides classes modeling parts of the Ruby `OpenSSL` library, which wraps
* an underlying OpenSSL or LibreSSL C library.
*/
private import internal.CryptoAlgorithmNames
bindingset[algorithmString]
private string algorithmRegex(string algorithmString) {
// Algorithms usually appear in names surrounded by characters that are not
// alphabetical characters in the same case. This handles the upper and lower
// case cases.
result =
"((^|.*[^A-Z])(" + algorithmString + ")([^A-Z].*|$))" +
// or...
"|" +
// For lowercase, we want to be careful to avoid being confused by camelCase
// hence we require two preceding uppercase letters to be sure of a case switch,
// or a preceding non-alphabetic character
"((^|.*[A-Z]{2}|.*[^a-zA-Z])(" + algorithmString.toLowerCase() + ")([^a-z].*|$))"
}
private string rankedInsecureAlgorithm(int i) {
// In this case we know these are being used for encryption, so we want to match
// weak hash algorithms and block modes as well.
result =
rank[i](string s |
isWeakEncryptionAlgorithm(s) or isWeakHashingAlgorithm(s) or isWeakBlockMode(s)
)
}
private string insecureAlgorithmString(int i) {
i = 1 and result = rankedInsecureAlgorithm(i)
or
result = rankedInsecureAlgorithm(i) + "|" + insecureAlgorithmString(i - 1)
}
/**
* Gets the regular expression used for matching strings that look like they
* contain an algorithm that is known to be insecure.
*/
private string getInsecureAlgorithmRegex() {
result = algorithmRegex(insecureAlgorithmString(max(int i | exists(rankedInsecureAlgorithm(i)))))
}
private string rankedSecureAlgorithm(int i) {
result = rank[i](string s | isStrongEncryptionAlgorithm(s))
}
private string secureAlgorithmString(int i) {
i = 1 and result = rankedSecureAlgorithm(i)
or
result = rankedSecureAlgorithm(i) + "|" + secureAlgorithmString(i - 1)
}
/**
* Gets a regular expression for matching strings that look like they
* contain an algorithm that is known to be secure.
*/
string getSecureAlgorithmRegex() {
result = algorithmRegex(secureAlgorithmString(max(int i | exists(rankedSecureAlgorithm(i)))))
}
/**
* Names of known ciphers supported by the Ruby `OpenSSL` library, and
* classification into strong and weak ciphers. Cipher support in practice
* depends on the underlying `OpenSSL`/`LibreSSL` library.
*/
module Ciphers {
/**
* Holds if `name` is a known `OpenSSL::Cipher`. Supported ciphers depend on the
* version of `OpenSSL` or `LibreSSL` specified when installing the `openssl` gem.
* Ciphers listed here are sourced from OpenSSL 1.1.1 and LibreSSL 3.4.1.
*
* In the general case, a name will include the cipher name, the key length,
* and the block encryption mode.
*
* Note that since the cipher name itself always comes first in these names
* and always uses a "-" to demark to block mode, we can safely uppercase
* these names when checking against an `algorithmRegex`.
*
* See https://ruby-doc.org/stdlib-3.0.1/libdoc/openssl/rdoc/OpenSSL/Cipher.html
*/
predicate isOpenSSLCipher(string name) {
name =
[
"aes-128-cbc", "aes-128-cbc-hmac-sha1", "aes-128-cbc-hmac-sha256", "aes-128-ccm",
"aes-128-cfb", "aes-128-cfb1", "aes-128-cfb8", "aes-128-ctr", "aes-128-ecb", "aes-128-gcm",
"aes-128-ocb", "aes-128-ofb", "aes-128-xts", "aes-192-cbc", "aes-192-ccm", "aes-192-cfb",
"aes-192-cfb1", "aes-192-cfb8", "aes-192-ctr", "aes-192-ecb", "aes-192-gcm", "aes-192-ocb",
"aes-192-ofb", "aes-256-cbc", "aes-256-cbc-hmac-sha1", "aes-256-cbc-hmac-sha256",
"aes-256-ccm", "aes-256-cfb", "aes-256-cfb1", "aes-256-cfb8", "aes-256-ctr", "aes-256-ecb",
"aes-256-gcm", "aes-256-ocb", "aes-256-ofb", "aes-256-xts", "aes128", "aes192", "aes256",
"aria-128-cbc", "aria-128-ccm", "aria-128-cfb", "aria-128-cfb1", "aria-128-cfb8",
"aria-128-ctr", "aria-128-ecb", "aria-128-gcm", "aria-128-ofb", "aria-192-cbc",
"aria-192-ccm", "aria-192-cfb", "aria-192-cfb1", "aria-192-cfb8", "aria-192-ctr",
"aria-192-ecb", "aria-192-gcm", "aria-192-ofb", "aria-256-cbc", "aria-256-ccm",
"aria-256-cfb", "aria-256-cfb1", "aria-256-cfb8", "aria-256-ctr", "aria-256-ecb",
"aria-256-gcm", "aria-256-ofb", "aria128", "aria192", "aria256", "bf", "bf-cbc", "bf-cfb",
"bf-ecb", "bf-ofb", "blowfish", "camellia-128-cbc", "camellia-128-cfb", "camellia-128-cfb1",
"camellia-128-cfb8", "camellia-128-ctr", "camellia-128-ecb", "camellia-128-ofb",
"camellia-192-cbc", "camellia-192-cfb", "camellia-192-cfb1", "camellia-192-cfb8",
"camellia-192-ctr", "camellia-192-ecb", "camellia-192-ofb", "camellia-256-cbc",
"camellia-256-cfb", "camellia-256-cfb1", "camellia-256-cfb8", "camellia-256-ctr",
"camellia-256-ecb", "camellia-256-ofb", "camellia128", "camellia192", "camellia256", "cast",
"cast-cbc", "cast5-cbc", "cast5-cfb", "cast5-ecb", "cast5-ofb", "chacha20",
"chacha20-poly1305", "des", "des-cbc", "des-cfb", "des-cfb1", "des-cfb8", "des-ecb",
"des-ede", "des-ede-cbc", "des-ede-cfb", "des-ede-ecb", "des-ede-ofb", "des-ede3",
"des-ede3-cbc", "des-ede3-cfb", "des-ede3-cfb1", "des-ede3-cfb8", "des-ede3-ecb",
"des-ede3-ofb", "des-ofb", "des3", "desx", "desx-cbc", "id-aes128-CCM", "id-aes128-GCM",
"id-aes192-CCM", "id-aes192-GCM", "id-aes256-CCM", "id-aes256-GCM", "idea", "idea-cbc",
"idea-cfb", "idea-ecb", "idea-ofb", "rc2", "rc2-128", "rc2-40", "rc2-40-cbc", "rc2-64",
"rc2-64-cbc", "rc2-cbc", "rc2-cfb", "rc2-ecb", "rc2-ofb", "rc4", "rc4-40", "rc4-hmac-md5",
"seed", "seed-cbc", "seed-cfb", "seed-ecb", "seed-ofb", "sm4", "sm4-cbc", "sm4-cfb",
"sm4-ctr", "sm4-ecb", "sm4-ofb", "AES-128-CBC", "AES-128-CBC-HMAC-SHA1", "AES-128-CFB",
"AES-128-CFB1", "AES-128-CFB8", "AES-128-CTR", "AES-128-ECB", "AES-128-OFB", "AES-128-XTS",
"AES-192-CBC", "AES-192-CFB", "AES-192-CFB1", "AES-192-CFB8", "AES-192-CTR", "AES-192-ECB",
"AES-192-OFB", "AES-256-CBC", "AES-256-CBC-HMAC-SHA1", "AES-256-CFB", "AES-256-CFB1",
"AES-256-CFB8", "AES-256-CTR", "AES-256-ECB", "AES-256-OFB", "AES-256-XTS", "AES128",
"AES192", "AES256", "BF", "BF-CBC", "BF-CFB", "BF-ECB", "BF-OFB", "CAMELLIA-128-CBC",
"CAMELLIA-128-CFB", "CAMELLIA-128-CFB1", "CAMELLIA-128-CFB8", "CAMELLIA-128-ECB",
"CAMELLIA-128-OFB", "CAMELLIA-192-CBC", "CAMELLIA-192-CFB", "CAMELLIA-192-CFB1",
"CAMELLIA-192-CFB8", "CAMELLIA-192-ECB", "CAMELLIA-192-OFB", "CAMELLIA-256-CBC",
"CAMELLIA-256-CFB", "CAMELLIA-256-CFB1", "CAMELLIA-256-CFB8", "CAMELLIA-256-ECB",
"CAMELLIA-256-OFB", "CAMELLIA128", "CAMELLIA192", "CAMELLIA256", "CAST", "CAST-cbc",
"CAST5-CBC", "CAST5-CFB", "CAST5-ECB", "CAST5-OFB", "ChaCha", "DES", "DES-CBC", "DES-CFB",
"DES-CFB1", "DES-CFB8", "DES-ECB", "DES-EDE", "DES-EDE-CBC", "DES-EDE-CFB", "DES-EDE-OFB",
"DES-EDE3", "DES-EDE3-CBC", "DES-EDE3-CFB", "DES-EDE3-CFB1", "DES-EDE3-CFB8",
"DES-EDE3-OFB", "DES-OFB", "DES3", "DESX", "DESX-CBC", "GOST 28147-89", "IDEA", "IDEA-CBC",
"IDEA-CFB", "IDEA-ECB", "IDEA-OFB", "RC2", "RC2-40-CBC", "RC2-64-CBC", "RC2-CBC", "RC2-CFB",
"RC2-ECB", "RC2-OFB", "RC4", "RC4-40", "RC4-HMAC-MD5", "SM4", "SM4-CBC", "SM4-CFB",
"SM4-CTR", "SM4-ECB", "SM4-OFB", "chacha", "gost89", "gost89-cnt", "gost89-ecb"
]
}
/**
* Gets the canonical cipher name in cases where this isn't simply an
* upcased version of the provided name. This may be because a default block
* mode is appended, or due to some other normalization.
*/
private string getSpecialCanonicalCipherName(string name) {
name = "AES128" and result = "AES-128-CBC"
or
name = "AES192" and result = "AES-192-CBC"
or
name = "AES256" and result = "AES-256-CBC"
or
name = "BF" and result = "BF-CBC"
or
name = "CAMELLIA128" and result = "CAMELLIA-128-CBC"
or
name = "CAMELLIA192" and result = "CAMELLIA-192-CBC"
or
name = "CAMELLIA256" and result = "CAMELLIA-256-CBC"
or
name = "CAST" and result = "CAST5-CBC"
or
name = "CAST-cbc" and result = "CAST5-CBC"
or
name = "ChaCha" and result = "ChaCha"
or
name = "DES" and result = "DES-CBC"
or
name = "DES3" and result = "DES-EDE3-CBC"
or
name = "DESX" and result = "DESX-CBC"
or
name = "GOST 28147-89" and result = "gost89"
or
name = "IDEA" and result = "IDEA-CBC"
or
name = "RC2" and result = "RC2-CBC"
or
name = "SM4" and result = "SM4-CBC"
or
name = "aes-128-ccm" and result = "id-aes128-CCM"
or
name = "aes-128-gcm" and result = "id-aes128-GCM"
or
name = "aes-192-ccm" and result = "id-aes192-CCM"
or
name = "aes-192-gcm" and result = "id-aes192-GCM"
or
name = "aes-256-ccm" and result = "id-aes256-CCM"
or
name = "aes-256-gcm" and result = "id-aes256-GCM"
or
name = "aes128" and result = "AES-128-CBC"
or
name = "aes192" and result = "AES-192-CBC"
or
name = "aes256" and result = "AES-256-CBC"
or
name = "bf" and result = "BF-CBC"
or
name = "blowfish" and result = "BF-CBC"
or
name = "camellia128" and result = "CAMELLIA-128-CBC"
or
name = "camellia192" and result = "CAMELLIA-192-CBC"
or
name = "camellia256" and result = "CAMELLIA-256-CBC"
or
name = "cast" and result = "CAST5-CBC"
or
name = "cast-cbc" and result = "CAST5-CBC"
or
name = "chacha" and result = "ChaCha"
or
name = "des" and result = "DES-CBC"
or
name = "des3" and result = "DES-EDE3-CBC"
or
name = "desx" and result = "DESX-CBC"
or
name = "gost89" and result = "gost89"
or
name = "gost89-cnt" and result = "gost89-cnt"
or
name = "gost89-ecb" and result = "gost89-ecb"
or
name = "id-aes128-CCM" and result = "id-aes128-CCM"
or
name = "id-aes128-GCM" and result = "id-aes128-GCM"
or
name = "id-aes192-CCM" and result = "id-aes192-CCM"
or
name = "id-aes192-GCM" and result = "id-aes192-GCM"
or
name = "id-aes256-CCM" and result = "id-aes256-CCM"
or
name = "id-aes256-GCM" and result = "id-aes256-GCM"
or
name = "idea" and result = "IDEA-CBC"
or
name = "rc2" and result = "RC2-CBC"
or
name = "sm4" and result = "SM4-CBC"
}
/**
* Gets the canonical version of `name`, as reported by `OpenSSL::Cipher#name`.
* No result if `name` is not a known OpenSSL cipher name.
*/
string getCanonicalCipherName(string name) {
isOpenSSLCipher(name) and
(
result = getSpecialCanonicalCipherName(name)
or
not exists(getSpecialCanonicalCipherName(name)) and
result = name.toUpperCase()
)
}
/**
* Holds if `name` is the name of an OpenSSL cipher that is known to be weak.
*/
predicate isWeakOpenSSLCipher(string name) {
isOpenSSLCipher(name) and
name.toUpperCase().regexpMatch(getInsecureAlgorithmRegex())
}
/**
* Holds if `name` is the name of an OpenSSL cipher that is known to be strong.
*/
predicate isStrongOpenSSLCipher(string name) {
isOpenSSLCipher(name) and
name.toUpperCase().regexpMatch(getSecureAlgorithmRegex()) and
// exclude algorithms that include a weak component
not name.toUpperCase().regexpMatch(getInsecureAlgorithmRegex())
}
}
private import Ciphers
/**
* An OpenSSL cipher.
*/
private newtype TOpenSSLCipher =
MkOpenSSLCipher(string name, boolean isWeak) {
isStrongOpenSSLCipher(name) and isWeak = false
or
isWeakOpenSSLCipher(name) and isWeak = true
}
/**
* A known OpenSSL cipher. This may include information about the block
* encryption mode, which can affect if the cipher is marked as being weak.
*/
class OpenSSLCipher extends MkOpenSSLCipher {
string name;
boolean isWeak;
OpenSSLCipher() { this = MkOpenSSLCipher(name, isWeak) }
/**
* Gets a name of this cipher.
*/
string getName() { result = name }
/**
* Gets a name of this cipher in canonical form.
*/
string getCanonicalName() { result = getCanonicalCipherName(this.getName()) }
/** Holds if this algorithm is weak. */
predicate isWeak() { isWeak = true }
/** Gets a textual representation of this element. */
string toString() { result = this.getCanonicalName() }
}

View File

@@ -0,0 +1,72 @@
/**
* Names of cryptographic algorithms, separated into strong and weak variants.
*
* The names are normalized: upper-case, no spaces, dashes or underscores.
*
* The names are inspired by the names used in real world crypto libraries.
*
* The classification into strong and weak are based on Wikipedia, OWASP and Google (2021).
*/
/**
* Holds if `name` corresponds to a strong hashing algorithm.
*/
predicate isStrongHashingAlgorithm(string name) {
name =
[
"DSA", "ED25519", "ES256", "ECDSA256", "ES384", "ECDSA384", "ES512", "ECDSA512", "SHA2",
"SHA224", "SHA256", "SHA384", "SHA512", "SHA3", "SHA3224", "SHA3256", "SHA3384", "SHA3512"
]
}
/**
* Holds if `name` corresponds to a weak hashing algorithm.
*/
predicate isWeakHashingAlgorithm(string name) {
name =
[
"HAVEL128", "MD2", "MD4", "MD5", "PANAMA", "RIPEMD", "RIPEMD128", "RIPEMD256", "RIPEMD160",
"RIPEMD320", "SHA0", "SHA1"
]
}
/**
* Holds if `name` corresponds to a strong encryption algorithm.
*/
predicate isStrongEncryptionAlgorithm(string name) {
name =
[
"AES", "AES128", "AES192", "AES256", "AES512", "AES-128", "AES-192", "AES-256", "AES-512",
"ARIA", "BLOWFISH", "BF", "ECIES", "CAST", "CAST5", "CAMELLIA", "CAMELLIA128", "CAMELLIA192",
"CAMELLIA256", "CAMELLIA-128", "CAMELLIA-192", "CAMELLIA-256", "CHACHA", "GOST", "GOST89",
"IDEA", "RABBIT", "RSA", "SEED", "SM4"
]
}
/**
* Holds if `name` corresponds to a weak encryption algorithm.
*/
predicate isWeakEncryptionAlgorithm(string name) {
name =
[
"DES", "3DES", "DES3", "TRIPLEDES", "DESX", "TDEA", "TRIPLEDEA", "ARC2", "RC2", "ARC4", "RC4",
"ARCFOUR", "ARC5", "RC5"
]
}
/**
* Holds if `name` corresponds to a strong password hashing algorithm.
*/
predicate isStrongPasswordHashingAlgorithm(string name) {
name = ["ARGON2", "PBKDF2", "BCRYPT", "SCRYPT"]
}
/**
* Holds if `name` corresponds to a weak password hashing algorithm.
*/
predicate isWeakPasswordHashingAlgorithm(string name) { name = "EVPKDF" }
/**
* Holds if `name` corresponds to a weak block cipher mode of operation.
*/
predicate isWeakBlockMode(string name) { name = "ECB" }

View File

@@ -0,0 +1,85 @@
weakHashingAlgorithms
| HAVEL128 |
| MD2 |
| MD4 |
| MD5 |
| PANAMA |
| RIPEMD |
| RIPEMD128 |
| RIPEMD160 |
| RIPEMD256 |
| RIPEMD320 |
| SHA0 |
| SHA1 |
strongHashingAlgorithms
| DSA |
| ECDSA256 |
| ECDSA384 |
| ECDSA512 |
| ED25519 |
| ES256 |
| ES384 |
| ES512 |
| SHA2 |
| SHA3 |
| SHA224 |
| SHA256 |
| SHA384 |
| SHA512 |
| SHA3224 |
| SHA3256 |
| SHA3384 |
| SHA3512 |
weakEncryptionAlgorithms
| 3DES |
| ARC2 |
| ARC4 |
| ARC5 |
| ARCFOUR |
| DES |
| DES3 |
| DESX |
| RC2 |
| RC4 |
| RC5 |
| TDEA |
| TRIPLEDEA |
| TRIPLEDES |
strongEncryptionAlgorithms
| AES |
| AES128 |
| AES192 |
| AES256 |
| AES512 |
| AES-128 |
| AES-192 |
| AES-256 |
| AES-512 |
| ARIA |
| BF |
| BLOWFISH |
| CAMELLIA |
| CAMELLIA128 |
| CAMELLIA192 |
| CAMELLIA256 |
| CAMELLIA-128 |
| CAMELLIA-192 |
| CAMELLIA-256 |
| CAST |
| CAST5 |
| CHACHA |
| ECIES |
| GOST |
| GOST89 |
| IDEA |
| RABBIT |
| RSA |
| SEED |
| SM4 |
weakPasswordHashingAlgorithms
| EVPKDF |
strongPasswordHashingAlgorithms
| ARGON2 |
| BCRYPT |
| PBKDF2 |
| SCRYPT |

View File

@@ -0,0 +1,14 @@
import ruby
import codeql.ruby.security.CryptoAlgorithms
query predicate weakHashingAlgorithms(HashingAlgorithm ha) { ha.isWeak() }
query predicate strongHashingAlgorithms(HashingAlgorithm ha) { not ha.isWeak() }
query predicate weakEncryptionAlgorithms(EncryptionAlgorithm ea) { ea.isWeak() }
query predicate strongEncryptionAlgorithms(EncryptionAlgorithm ea) { not ea.isWeak() }
query predicate weakPasswordHashingAlgorithms(PasswordHashingAlgorithm pha) { pha.isWeak() }
query predicate strongPasswordHashingAlgorithms(PasswordHashingAlgorithm pha) { not pha.isWeak() }

View File

@@ -0,0 +1,274 @@
weakOpenSSLCipherAlgorithms
| AES-128-CBC-HMAC-SHA1 |
| AES-128-CBC-HMAC-SHA1 |
| AES-128-ECB |
| AES-128-ECB |
| AES-192-ECB |
| AES-192-ECB |
| AES-256-CBC-HMAC-SHA1 |
| AES-256-CBC-HMAC-SHA1 |
| AES-256-ECB |
| AES-256-ECB |
| ARIA-128-ECB |
| ARIA-192-ECB |
| ARIA-256-ECB |
| BF-ECB |
| BF-ECB |
| CAMELLIA-128-ECB |
| CAMELLIA-128-ECB |
| CAMELLIA-192-ECB |
| CAMELLIA-192-ECB |
| CAMELLIA-256-ECB |
| CAMELLIA-256-ECB |
| CAST5-ECB |
| CAST5-ECB |
| DES-CBC |
| DES-CBC |
| DES-CBC |
| DES-CBC |
| DES-CFB |
| DES-CFB |
| DES-CFB1 |
| DES-CFB1 |
| DES-CFB8 |
| DES-CFB8 |
| DES-ECB |
| DES-ECB |
| DES-EDE |
| DES-EDE |
| DES-EDE3 |
| DES-EDE3 |
| DES-EDE3-CBC |
| DES-EDE3-CBC |
| DES-EDE3-CBC |
| DES-EDE3-CBC |
| DES-EDE3-CFB |
| DES-EDE3-CFB |
| DES-EDE3-CFB1 |
| DES-EDE3-CFB1 |
| DES-EDE3-CFB8 |
| DES-EDE3-CFB8 |
| DES-EDE3-ECB |
| DES-EDE3-OFB |
| DES-EDE3-OFB |
| DES-EDE-CBC |
| DES-EDE-CBC |
| DES-EDE-CFB |
| DES-EDE-CFB |
| DES-EDE-ECB |
| DES-EDE-OFB |
| DES-EDE-OFB |
| DES-OFB |
| DES-OFB |
| DESX-CBC |
| DESX-CBC |
| DESX-CBC |
| DESX-CBC |
| IDEA-ECB |
| IDEA-ECB |
| RC2-40 |
| RC2-40-CBC |
| RC2-40-CBC |
| RC2-64 |
| RC2-64-CBC |
| RC2-64-CBC |
| RC2-128 |
| RC2-CBC |
| RC2-CBC |
| RC2-CBC |
| RC2-CBC |
| RC2-CFB |
| RC2-CFB |
| RC2-ECB |
| RC2-ECB |
| RC2-OFB |
| RC2-OFB |
| RC4 |
| RC4 |
| RC4-40 |
| RC4-40 |
| RC4-HMAC-MD5 |
| RC4-HMAC-MD5 |
| SEED-ECB |
| SM4-ECB |
| SM4-ECB |
| gost89-ecb |
strongOpenSSLCipherAlgorithms
| AES-128-CBC |
| AES-128-CBC |
| AES-128-CBC |
| AES-128-CBC |
| AES-128-CBC-HMAC-SHA256 |
| AES-128-CFB |
| AES-128-CFB |
| AES-128-CFB1 |
| AES-128-CFB1 |
| AES-128-CFB8 |
| AES-128-CFB8 |
| AES-128-CTR |
| AES-128-CTR |
| AES-128-OCB |
| AES-128-OFB |
| AES-128-OFB |
| AES-128-XTS |
| AES-128-XTS |
| AES-192-CBC |
| AES-192-CBC |
| AES-192-CBC |
| AES-192-CBC |
| AES-192-CFB |
| AES-192-CFB |
| AES-192-CFB1 |
| AES-192-CFB1 |
| AES-192-CFB8 |
| AES-192-CFB8 |
| AES-192-CTR |
| AES-192-CTR |
| AES-192-OCB |
| AES-192-OFB |
| AES-192-OFB |
| AES-256-CBC |
| AES-256-CBC |
| AES-256-CBC |
| AES-256-CBC |
| AES-256-CBC-HMAC-SHA256 |
| AES-256-CFB |
| AES-256-CFB |
| AES-256-CFB1 |
| AES-256-CFB1 |
| AES-256-CFB8 |
| AES-256-CFB8 |
| AES-256-CTR |
| AES-256-CTR |
| AES-256-OCB |
| AES-256-OFB |
| AES-256-OFB |
| AES-256-XTS |
| AES-256-XTS |
| ARIA128 |
| ARIA192 |
| ARIA256 |
| ARIA-128-CBC |
| ARIA-128-CCM |
| ARIA-128-CFB |
| ARIA-128-CFB1 |
| ARIA-128-CFB8 |
| ARIA-128-CTR |
| ARIA-128-GCM |
| ARIA-128-OFB |
| ARIA-192-CBC |
| ARIA-192-CCM |
| ARIA-192-CFB |
| ARIA-192-CFB1 |
| ARIA-192-CFB8 |
| ARIA-192-CTR |
| ARIA-192-GCM |
| ARIA-192-OFB |
| ARIA-256-CBC |
| ARIA-256-CCM |
| ARIA-256-CFB |
| ARIA-256-CFB1 |
| ARIA-256-CFB8 |
| ARIA-256-CTR |
| ARIA-256-GCM |
| ARIA-256-OFB |
| BF-CBC |
| BF-CBC |
| BF-CBC |
| BF-CBC |
| BF-CBC |
| BF-CFB |
| BF-CFB |
| BF-OFB |
| BF-OFB |
| CAMELLIA-128-CBC |
| CAMELLIA-128-CBC |
| CAMELLIA-128-CBC |
| CAMELLIA-128-CBC |
| CAMELLIA-128-CFB |
| CAMELLIA-128-CFB |
| CAMELLIA-128-CFB1 |
| CAMELLIA-128-CFB1 |
| CAMELLIA-128-CFB8 |
| CAMELLIA-128-CFB8 |
| CAMELLIA-128-CTR |
| CAMELLIA-128-OFB |
| CAMELLIA-128-OFB |
| CAMELLIA-192-CBC |
| CAMELLIA-192-CBC |
| CAMELLIA-192-CBC |
| CAMELLIA-192-CBC |
| CAMELLIA-192-CFB |
| CAMELLIA-192-CFB |
| CAMELLIA-192-CFB1 |
| CAMELLIA-192-CFB1 |
| CAMELLIA-192-CFB8 |
| CAMELLIA-192-CFB8 |
| CAMELLIA-192-CTR |
| CAMELLIA-192-OFB |
| CAMELLIA-192-OFB |
| CAMELLIA-256-CBC |
| CAMELLIA-256-CBC |
| CAMELLIA-256-CBC |
| CAMELLIA-256-CBC |
| CAMELLIA-256-CFB |
| CAMELLIA-256-CFB |
| CAMELLIA-256-CFB1 |
| CAMELLIA-256-CFB1 |
| CAMELLIA-256-CFB8 |
| CAMELLIA-256-CFB8 |
| CAMELLIA-256-CTR |
| CAMELLIA-256-OFB |
| CAMELLIA-256-OFB |
| CAST5-CBC |
| CAST5-CBC |
| CAST5-CBC |
| CAST5-CBC |
| CAST5-CBC |
| CAST5-CBC |
| CAST5-CFB |
| CAST5-CFB |
| CAST5-OFB |
| CAST5-OFB |
| CHACHA20 |
| CHACHA20-POLY1305 |
| ChaCha |
| ChaCha |
| IDEA-CBC |
| IDEA-CBC |
| IDEA-CBC |
| IDEA-CBC |
| IDEA-CFB |
| IDEA-CFB |
| IDEA-OFB |
| IDEA-OFB |
| SEED |
| SEED-CBC |
| SEED-CFB |
| SEED-OFB |
| SM4-CBC |
| SM4-CBC |
| SM4-CBC |
| SM4-CBC |
| SM4-CFB |
| SM4-CFB |
| SM4-CTR |
| SM4-CTR |
| SM4-OFB |
| SM4-OFB |
| gost89 |
| gost89 |
| gost89-cnt |
| id-aes128-CCM |
| id-aes128-CCM |
| id-aes128-GCM |
| id-aes128-GCM |
| id-aes192-CCM |
| id-aes192-CCM |
| id-aes192-GCM |
| id-aes192-GCM |
| id-aes256-CCM |
| id-aes256-CCM |
| id-aes256-GCM |
| id-aes256-GCM |
missingOpenSSLCipherAlgorithms

View File

@@ -0,0 +1,11 @@
import ruby
import codeql.ruby.security.OpenSSL
query predicate weakOpenSSLCipherAlgorithms(OpenSSLCipher c) { c.isWeak() }
query predicate strongOpenSSLCipherAlgorithms(OpenSSLCipher c) { not c.isWeak() }
query predicate missingOpenSSLCipherAlgorithms(string name) {
Ciphers::isOpenSSLCipher(name) and
not exists(OpenSSLCipher c | c.getName() = name)
}