hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-30 03:05:15 +02:00
Code Issues Packages Projects Releases Wiki Activity

C#: Address review comments

Browse Source
This commit is contained in:
Tom Hvitved
2019-03-05 19:27:36 +01:00
parent b2ede5e2a1
commit 0afb85cb91
1 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
csharp/ql/src/semmle/code/csharp/controlflow/internal/Completion.qll
View File

@@ -194,7 +194,7 @@ private class CoreLib extends Assembly {
*/
pragma[noinline]
private predicate assemblyCompiledWithCoreLib(Assembly a, CoreLib core) {
a.getAnAttribute().getType().getABaseType*().getALocation() = core
a.getAnAttribute().getType().getBaseClass*().(SystemAttributeClass).getALocation() = core
}
/** A control flow element that is inside a `try` block. */
@@ -266,7 +266,7 @@ private class TriedControlFlowElement extends ControlFlowElement {
private CoreLib getCoreLibFromACatchClause() {
exists(SpecificCatchClause scc | scc = try.getACatchClause() |
result = scc.getCaughtExceptionType().getABaseType*().getALocation()
result = scc.getCaughtExceptionType().getBaseClass*().(SystemExceptionClass).getALocation()
)
}
@@ -289,12 +289,12 @@ private class TriedControlFlowElement extends ControlFlowElement {
}
Class getAThrownException() {
exists(string name |
result = this.getAThrownExceptionFromPlausibleCoreLib(name) |
exists(string name | result = this.getAThrownExceptionFromPlausibleCoreLib(name) |
result = min(Class c |
c = this.getAThrownExceptionFromPlausibleCoreLib(name) |
c order by c.getLocation().(Assembly).getFullName()
)
c = this.getAThrownExceptionFromPlausibleCoreLib(name)
|
c order by c.getLocation().(Assembly).getFullName()
)
)
}
}