hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-05-02 04:05:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

include startsWith/endsWith checks in js/missing-origin-check

Browse Source
This commit is contained in:
Erik Krogh Kristensen
2022-04-25 15:28:50 +02:00
parent fe3d71ebc2
commit 0a26e891a2
2 changed files with 17 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
javascript/ql/src/Security/CWE-020/MissingOriginCheck.ql
View File

@@ -66,6 +66,16 @@ predicate hasOriginCheck(PostMessageHandler handler) {
or
// set.includes(event.source)
exists(InclusionTest test | sourceOrOrigin(handler).flowsTo(test.getContainedNode()))
or
// "safeOrigin".startsWith(event.origin)
exists(StringOps::StartsWith starts |
origin(DataFlow::TypeTracker::end(), handler).flowsTo(starts.getSubstring())
)
or
// "safeOrigin".endsWith(event.origin)
exists(StringOps::EndsWith ends |
origin(DataFlow::TypeTracker::end(), handler).flowsTo(ends.getSubstring())
)
}
from PostMessageHandler handler

8
javascript/ql/test/query-tests/Security/CWE-020/MissingOriginCheck/tst.js
View File

@@ -61,4 +61,10 @@ function is_valid_origin(origin) {
warn("invalid origin: " + origin);
}
return valid;
}
}
window.onmessage = event => { // OK - the check is OK
if ("https://www.example.com".startsWith(event.origin)) {
// do something
}
}