hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-26 17:25:19 +02:00
Code Issues Packages Projects Releases Wiki Activity

C++: Fix swapped arguments in 'invalidPointerToDerefSource'.

Browse Source
This commit is contained in:
Mathias Vorreiter Pedersen
2023-07-21 16:51:52 +01:00
parent 69ea7d92cd
commit 0859c4f926
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
cpp/ql/lib/semmle/code/cpp/security/InvalidPointerDereference/InvalidPointerToDereference.qll
View File

@@ -102,8 +102,10 @@ private predicate invalidPointerToDerefSource(
// delta is the constant difference between the pointer-arithmetic instruction
// and the instruction computing the address for which we will search for a dereference.
AllocToInvalidPointer::pointerAddInstructionHasBounds(source1, pai, _, delta0) and
bounded2(derefSource.asInstruction(), pai, delta) and
delta >= 0 and
// pai <= derefSource + delta and delta <= 0 is equivalent to
// derefSource >= pai + delta and delta >= 0
bounded1(pai, derefSource.asInstruction(), delta) and
delta <= 0 and
// TODO: This condition will go away once #13725 is merged, and then we can make `Barrier2`
// private to `AllocationToInvalidPointer.qll`.
not derefSource.getBasicBlock() = AllocToInvalidPointer::Barrier2::getABarrierBlock(delta0)