hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-16 16:53:25 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #15045 from aschackmull/java/fix-cp

Browse Source 
Java: Fix accidental cartesian product.
This commit is contained in:
Anders Schack-Mulligen
2023-12-08 15:43:01 +01:00
committed by GitHub
parent 1ea2f89e27 7ee3068fe7
commit 0618568cdc
1 changed files with 2 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
java/ql/lib/semmle/code/java/dataflow/internal/ContainerFlow.qll
View File

@@ -4,10 +4,6 @@ import semmle.code.java.Maps
private import semmle.code.java.dataflow.SSA
private import DataFlowUtil
private class ArrayType extends RefType {
ArrayType() { this.getSourceDeclaration().getASourceSupertype*() instanceof Array }
}
private class EntryType extends RefType {
EntryType() {
this.getSourceDeclaration().getASourceSupertype*().hasQualifiedName("java.util", "Map$Entry")
@@ -455,7 +451,7 @@ predicate arrayStoreStep(Node node1, Node node2) {
arr = node2.(PostUpdateNode).getPreUpdateNode().asExpr() and
call.getArgument(1) = node1.asExpr() and
call.getQualifier() = arr and
arr.getType() instanceof ArrayType and
arr.getType() instanceof Array and
call.getCallee().getName() = "set"
)
}
@@ -485,7 +481,7 @@ predicate arrayReadStep(Node node1, Node node2, Type elemType) {
exists(Expr arr, Call call |
arr = node1.asExpr() and
call = node2.asExpr() and
arr.getType() instanceof ArrayType and
arr.getType().(Array).getComponentType() = elemType and
call.getCallee().getName() = "get" and
call.getQualifier() = arr
)