hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-01-29 22:32:58 +01:00
Code Issues Packages Projects Releases Wiki Activity

Address review comments

Browse Source
This commit is contained in:
Sauyon Lee
2020-03-27 04:03:30 -07:00
parent a4f1e2b527
commit 05761bc2cd
1 changed files with 15 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
ql/src/semmle/go/security/OpenUrlRedirectCustomizations.qll
View File

@@ -46,19 +46,26 @@ module OpenUrlRedirect {
UntrustedFlowAsSource() {
// exclude some fields and methods of URLs that are generally not attacker-controllable for
// open redirect exploits
not exists(string fieldName |
this.(DataFlow::FieldReadNode).getField().hasQualifiedName("net/http", "Request", fieldName)
not exists(Field f, string fieldName |
f.hasQualifiedName("net/http", "Request", fieldName) and
this = f.getARead()
|
fieldName = "Header" or fieldName = "Trailer"
fieldName = "Body" or
fieldName = "GetBody" or
fieldName = "PostForm" or
fieldName = "MultipartForm" or
fieldName = "Header" or
fieldName = "Trailer"
) and
not exists(string methName |
this
.(DataFlow::MethodCallNode)
.getTarget()
.hasQualifiedName("net/http", "Request", methName)
not exists(Method m, string methName |
m.hasQualifiedName("net/http", "Request", methName) and
this = m.getACall()
|
methName = "Cookie" or
methName = "Cookies" or
methName = "FormValue" or
methName = "MultipartReader" or
methName = "PostFormValues" or
methName = "Referer" or
methName = "UserAgent"
)