hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-27 17:55:19 +02:00
Code Issues Packages Projects Releases Wiki Activity

Swift: resolve symlinks

Browse Source
This commit is contained in:
Alex Denisov
2022-05-13 15:18:48 +02:00
parent d7f4c6fb0b
commit 043b1b9c4a
1 changed files with 11 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
swift/extractor/SwiftDispatcher.h
View File

@@ -136,7 +136,7 @@ class SwiftDispatcher {
std::string filepath = getFilepath(start);
auto fileLabel = arena.allocateLabel<FileTag>();
trap.assignKey(fileLabel, filepath);
/// TODO: do not emit duplicate trap entries for Files
// TODO: do not emit duplicate trap entries for Files
trap.emit(FilesTrap{fileLabel, filepath});
auto [startLine, startColumn] = sourceManager.getLineAndColumnInBuffer(start);
auto [endLine, endColumn] = sourceManager.getLineAndColumnInBuffer(end);
@@ -148,15 +148,22 @@ class SwiftDispatcher {
}
std::string getFilepath(swift::SourceLoc loc) {
/// TODO: this needs more testing
// TODO: this needs more testing
// TODO: check canonicaliztion of names on a case insensitive filesystems
// TODO: make symlink resolution conditional on CODEQL_PRESERVE_SYMLINKS=true
std::string displayName = sourceManager.getDisplayNameForLoc(loc).str();
llvm::SmallString<PATH_MAX> filePath(displayName);
if (std::error_code ec = llvm::sys::fs::make_absolute(filePath)) {
std::cerr << "Cannot make absolute path: '" << displayName << "': " << ec.message() << "\n";
return {};
}
llvm::sys::path::remove_dots(filePath);
return filePath.str().str();
llvm::SmallString<PATH_MAX> realPath;
if (std::error_code ec = llvm::sys::fs::real_path(filePath, realPath)) {
std::cerr << "Cannot get real path: '" << filePath.str().str() << "': " << ec.message()
<< "\n";
return {};
}
return realPath.str().str();
}
// TODO: The following methods are supposed to redirect TRAP emission to correpsonding visitors,