Add new style build constraints and add test for the old style

ql/test/library-tests/semmle/go/controlflow/ControlFlowGraph/linux.go

@@ -1,3 +1,4 @@
+//go:build linux
 // +build linux
 
 package main

ql/test/library-tests/semmle/go/controlflow/ControlFlowGraph/nonlinux.go

@@ -1,3 +1,4 @@
+//go:build !linux
 // +build !linux
 
 package main

ql/test/library-tests/semmle/go/frameworks/StdlibTaintFlow/Syscall_non_win.go

@@ -1,5 +1,6 @@
 // Code generated by https://github.com/gagliardetto/codebox. DO NOT EDIT.
 
+//go:build !windows
 // +build !windows
 
 package main

ql/test/query-tests/RedundantCode/CompareIdenticalValues/constants.go

@@ -1,4 +1,5 @@
-// +build linux, amd64
+//go:build (linux && ignore) || amd64
+// +build linux,ignore amd64
 
 package main
 

ql/test/query-tests/RedundantCode/ExprHasNoEffect/tst.go

@@ -1,3 +1,4 @@
+//go:build linux
 // +build linux
 
 package main

ql/test/query-tests/RedundantCode/ExprHasNoEffect/tst_nonlinux.go

@@ -1,3 +1,4 @@
+//go:build !linux
 // +build !linux
 
 package main

ql/test/query-tests/Security/CWE-681/Test32BitArchitectureBuildConstraints.go

@@ -1,3 +1,4 @@
+//go:build (386 || amd64p32 || arm || armbe || mips || mipsle || mips64p32 || mips64p32le || ppc || s390 || sparc) && gc && go1.4
 // +build 386 amd64p32 arm armbe mips mipsle mips64p32 mips64p32le ppc s390 sparc
 // +build gc
 // +build go1.4

ql/test/query-tests/Security/CWE-681/Test64BitArchitectureBuildConstraints.go

@@ -1,3 +1,4 @@
+//go:build (amd64 || arm64 || arm64be || ppc64 || ppc64le || mips64 || mips64le || s390x || sparc64) && gc && go1.4
 // +build amd64 arm64 arm64be ppc64 ppc64le mips64 mips64le s390x sparc64
 // +build gc
 // +build go1.4

ql/test/query-tests/Security/CWE-681/TestNoArchitectureBuildConstraints.go

@@ -1,5 +1,5 @@
-// +build gc
-// +build go1.4
+//go:build gc && go1.4
+// +build gc,go1.4
 
 package main
 

ql/test/query-tests/Security/CWE-681/TestOldBuildConstraints.go

@@ -0,0 +1,29 @@
+// autoformat-ignore (gofmt adds new style build constraints)
+// +build amd64 arm64 arm64be ppc64 ppc64le mips64 mips64le s390x sparc64
+// +build gc
+// +build go1.4
+
+package main
+
+import (
+	"strconv"
+)
+
+func oldTestIntSink64() {
+	{
+		parsed, err := strconv.ParseInt("3456", 10, 64)
+		if err != nil {
+			panic(err)
+		}
+		_ = int(parsed)  // OK
+		_ = uint(parsed) // OK
+	}
+	{
+		parsed, err := strconv.ParseUint("3456", 10, 64)
+		if err != nil {
+			panic(err)
+		}
+		_ = int(parsed)  // OK
+		_ = uint(parsed) // OK
+	}
+}