hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-01-29 14:23:03 +01:00
Code Issues Packages Projects Releases Wiki Activity

Remove redundancy

Browse Source
This commit is contained in:
Slavomir
2020-06-30 23:00:19 +03:00
parent c5354a88f0
commit 036a1faffa
1 changed files with 1 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
ql/src/experimental/Unsafe/WrongUsageOfUnsafe.ql
View File

@@ -63,7 +63,6 @@ predicate castShortArrayToLongerArray(
(
arrFrom = getBaseType(castLittle.getOperand().getType())
or
castLittle.getOperand().getChildExpr(0) instanceof IndexExpr and
arrFrom = castLittle.getOperand().getChildExpr(0).(IndexExpr).getBase().getType()
) and
arrTo.getLength() > 0 and //TODO
@@ -90,10 +89,7 @@ predicate castTypeToArray(DataFlow::PathNode source, DataFlow::PathNode sink, st
arrTo = getBaseType(castBig.getTypeExpr().getType()) and
not (typeFrom instanceof ArrayType or typeFrom.getUnderlyingType() instanceof ArrayType) and
not typeFrom instanceof PointerType and
not (
castLittle.getOperand().getChildExpr(0) instanceof IndexExpr and
castLittle.getOperand().getChildExpr(0).(IndexExpr).getBase().getType() instanceof ArrayType
) and
not castLittle.getOperand().getChildExpr(0).(IndexExpr).getBase().getType() instanceof ArrayType and
typeFrom = getBaseType(castLittle.getOperand().getType()) and
message =
"Dangerous type up-casting to [" + arrTo.getLength() + "]" + arrTo.getElementType() + " from "