hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-01-29 14:23:03 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #368 from sauyon/xpath-fix

Browse Source 
Update XPathExpressionString to match the Range pattern
This commit is contained in:
Chris Smowton
2020-10-08 09:24:04 +01:00
committed by GitHub
parent c8a2d30e39 43de6ea836
commit 024e8ef715
2 changed files with 15 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
ql/src/semmle/go/frameworks/XPath.qll
View File

@@ -6,12 +6,25 @@ import go
/** Provides classes for working with XPath-related APIs. */
module XPath {
/**
* A data-flow node whose string value is interpreted as (part of) an XPath expression.
*
* Extend this class to refine existing API models. If you want to model new APIs,
* extend `XPath::XPathExpressionString::Range` instead.
*/
class XPathExpressionString extends DataFlow::Node {
XPathExpressionString::Range self;
XPathExpressionString() { this = self }
}
/** Provides classes for working with XPath expression strings. */
module XPathExpressionString {
/**
* A data-flow node whose string value is interpreted as (part of) an XPath expression.
*
* Extend this class to model new APIs.
* Extend this class to model new APIs. If you want to refine existing API models,
* extend `XPath::XPathExpressionString` instead.
*/
abstract class Range extends DataFlow::Node { }

2
ql/src/semmle/go/security/XPathInjectionCustomizations.qll
View File

@@ -36,6 +36,6 @@ module XPathInjection {
/** An XPath expression string, considered as a taint sink for XPath injection. */
class XPathExpressionStringAsSink extends Sink {
XPathExpressionStringAsSink() { this instanceof XPath::XPathExpressionString::Range }
XPathExpressionStringAsSink() { this instanceof XPath::XPathExpressionString }
}
}