Commit Graph

844 Commits

Author SHA1 Message Date
Dave Bartolomeo
1dc6111fba Switch to built-in VS Code test UI unconditionally 2024-01-11 10:47:48 -05:00
Koen Vlaswinkel
70c2beb510 Remove import cycle for distribution manager 2024-01-08 13:49:25 +01:00
Koen Vlaswinkel
9d6962ede2 Enforce consistent type imports 2024-01-05 17:13:45 +01:00
Koen Vlaswinkel
5c7efe5116 Merge pull request #3200 from github/koesie10/remove-namespace-imports
Remove unnecessary namespace imports
2024-01-05 14:53:29 +01:00
Nora
1d42d4848b Merge pull request #3189 from github/nora/make-model-editor-open-cancellable
CodeQL model editor: user should be able to stop modeling before the main editor view is open
2024-01-05 13:50:08 +01:00
Koen Vlaswinkel
034bfc230c Remove unnecessary namespace imports
This removes all unnecessary namespace imports. The only namespace
imports that are left are those that are needed for spying on functions
in tests.
2024-01-05 10:42:36 +01:00
Nora
6a65094720 Make preparation progress bar cancellable 2024-01-03 15:15:17 +00:00
Robert
c575edec71 Move releases-api-consumer.test.ts from no-workspace to unit-tests 2024-01-03 10:54:17 +00:00
Robert
6d1cf0887a Pull out ReleasesApiConsumer to its own file 2024-01-03 10:46:15 +00:00
Koen Vlaswinkel
1ad20fa354 Merge pull request #3163 from github/koesie10/queries-panel-no-cli-server
Do not use the CLI server to determine query pack language
2024-01-03 09:36:20 +01:00
Koen Vlaswinkel
fa7ecb782e Merge pull request #3175 from github/koesie10/rename-new-messages
Remove remaining references to new messages/new query server
2024-01-02 13:44:00 +01:00
Robert
f5dbcc8cc1 Merge pull request #3127 from github/robertbrignull/nightly-codeql
Provide option to point ReleasesApiConsumer at nightly builds repo
2024-01-02 12:21:38 +00:00
Robert
c423505c04 Update extensions/ql-vscode/test/vscode-tests/no-workspace/codeql-cli/distribution.test.ts
Co-authored-by: Koen Vlaswinkel <koesie10@users.noreply.github.com>
2024-01-02 12:05:43 +00:00
Koen Vlaswinkel
767c3cc35c Remove references to new query server 2023-12-22 16:51:26 +01:00
Koen Vlaswinkel
a6d9b6bbec Rename new-query.test.ts to query-server-client.test.ts 2023-12-22 16:20:21 +01:00
Koen Vlaswinkel
f139f1ebf8 Rename new-messages.ts to messages.ts 2023-12-22 16:18:30 +01:00
Koen Vlaswinkel
d227af4c7b Merge pull request #3172 from github/koesie10/remove-legacy-messages
Remove legacy messages
2023-12-22 16:14:45 +01:00
Koen Vlaswinkel
2b625c85e8 Merge pull request #3173 from github/koesie10/eslint-plugin-import
Add `eslint-plugin-import`
2023-12-22 16:08:46 +01:00
Koen Vlaswinkel
7a7092de0d Add eslint-plugin-import
It seems like we had some rules that disabled rules of this plugin, but
we didn't actually have it installed. I've now installed it, used the
recommended configuration, and removed our own disable rules. I've fixed
any errors that this introduced.
2023-12-21 17:02:37 +01:00
Koen Vlaswinkel
82c7dd52be Remove legacy messages 2023-12-21 16:19:22 +01:00
Koen Vlaswinkel
d0f122ad87 Remove formatLegacyMessage 2023-12-21 16:11:47 +01:00
Koen Vlaswinkel
ef575acd59 Remove legacy result from query history items
The legacy result was populated based on information that is already
present in `CompletedQueryInfo` anyway. Old history items which only
have the legacy result populated have not been created for at least 30
days now since the legacy query runner hasn't been used for quite a
while now.
2023-12-21 16:08:39 +01:00
Koen Vlaswinkel
785a5fa48a Remove QueryRunner abstraction
Since we're only supporting the new query server, we can remove the
`QueryRunner` abstraction and just use the `NewQueryRunner` as a
concrete `QueryRunner` without an abstract base class. This simplifies
the code of the query server and removes some unnecessary indirection.
2023-12-21 16:03:28 +01:00
Koen Vlaswinkel
4e4345f0c2 Merge remote-tracking branch 'origin/main' into koesie10/yauzl-progress 2023-12-21 13:41:43 +01:00
Koen Vlaswinkel
7554c415af Do not use the CLI server to determine query pack language
This removes the use of the CLI `codeql resolve library-path` command to
detect the language of a query pack. Instead, it uses the `qlpack.yml`
file to determine the language. This is slightly less correct since it
only works for `codeql/${language}-all` dependencies, but it is much
faster and more reliable. It also doesn't result in the CLI server
restarting for invalid query packs (such as in the `github/codeql`
repository or in any workspaces containing it).
2023-12-21 12:20:12 +01:00
Koen Vlaswinkel
f99432153b Add tests for promptGitHubRepositoryDownload 2023-12-21 10:56:34 +01:00
Robert
e56503249d Add tests that cover the new semver options 2023-12-20 16:25:57 +00:00
Robert
4140303b5c Fix arguemnts to calls to getLatestRelease 2023-12-20 16:25:54 +00:00
Koen Vlaswinkel
8cbd77cf65 Report progress while extracting CodeQL CLI distribution in tests 2023-12-20 10:24:07 +01:00
Koen Vlaswinkel
641f714fa4 Extract downloadWithProgress function in ensureCli 2023-12-20 10:24:07 +01:00
Koen Vlaswinkel
9038586aab Rename unzipToDirectory to unzipToDirectorySequentially 2023-12-19 14:26:03 +01:00
Koen Vlaswinkel
f736adc4f1 Merge pull request #3152 from github/koesie10/distribution-yauzl
Switch to `yauzl` for CodeQL CLI
2023-12-19 14:18:59 +01:00
Koen Vlaswinkel
fdc36ad36b Switch to yauzl for CodeQL CLI
This switches the CodeQL CLI download to `yauzl` instead of `unzipper`.
There should be no changes in behavior. I tested this manually on
Insiders by removing the distribution directory and this successfully
downloaded and extracted the CLI.
2023-12-19 13:07:31 +01:00
Koen Vlaswinkel
3f6c1055e4 Merge remote-tracking branch 'origin/main' into koesie10/variant-analysis-yauzl 2023-12-19 13:03:54 +01:00
Koen Vlaswinkel
b833591d1e Merge pull request #3150 from github/koesie10/archive-filesystem-yauzl
Switch to `yauzl` in the archive filesystem provider
2023-12-19 12:14:31 +01:00
Koen Vlaswinkel
770834756a Switch to yauzl for variant analysis results 2023-12-18 15:10:36 +01:00
Koen Vlaswinkel
bc0506d058 Switch to yauzl in the archive filesystem provider 2023-12-18 14:22:22 +01:00
Koen Vlaswinkel
14b2282015 Remove fallback behavior for database unbundle
The CodeQL CLI always supports the `database unbundle` command since
140d369098
so we can remove the fallback behavior.

There were some places which were not passing in the CodeQL CLI server,
but these always have access to the CLI server, so this just passes them
in.

The only change in behavior (in terms of the fallback behavior) is in
the `new-query.test.ts` test.
2023-12-18 14:19:59 +01:00
Koen Vlaswinkel
ce83d1df23 Replace tmp package for modeled-method-fs.test.ts 2023-12-14 16:09:30 +01:00
Koen Vlaswinkel
d63b756520 Set unsafeCleanup for all test tmp directories
We want to remove the tmp directories after tests, even if they are not
empty.
2023-12-14 15:08:45 +01:00
Charis Kyriakou
598f2eb3f2 Allow the CodeQL CLI path to be set from an environment variable (#3118) 2023-12-14 09:03:25 +00:00
Koen Vlaswinkel
0b7b6f1b13 Merge remote-tracking branch 'origin/main' into koesie10/npm-upgrade 2023-12-13 14:40:30 +01:00
Koen Vlaswinkel
bc1c08c653 Merge remote-tracking branch 'origin/main' into koesie10/separate-bqrs-types 2023-12-12 14:15:24 +01:00
Koen Vlaswinkel
7f332e3374 Add retryCount to mocked Octokit responses 2023-12-11 16:41:15 +01:00
Nora
8acff5ce72 Remove from other files 2023-12-08 12:42:27 +00:00
Nora
9f667ef2d2 db-panel: remove tests and functionality 2023-12-06 10:18:35 +00:00
Koen Vlaswinkel
cf6abc43b1 Remove unused legacy messages 2023-11-28 16:35:30 +01:00
Koen Vlaswinkel
ce20c7f6a4 Remove legacy query server 2023-11-28 16:11:26 +01:00
Koen Vlaswinkel
f0a354917e Fix tests 2023-11-27 14:14:04 +01:00
Koen Vlaswinkel
082c5e4a31 Prefix BQRS types with Bqrs 2023-11-27 13:38:04 +01:00