From fd1c7f338d6be92fd1f1e43a1ffba5caa188a34a Mon Sep 17 00:00:00 2001
From: Robert <robertbrignull@github.com>
Date: Mon, 4 Sep 2023 15:30:09 +0100
Subject: [PATCH] Make onChange optional

---
 extensions/ql-vscode/src/view/common/Dropdown.tsx            | 2 +-
 .../ql-vscode/src/view/model-editor/InProgressDropdown.tsx   | 5 -----
 2 files changed, 1 insertion(+), 6 deletions(-)

diff --git a/extensions/ql-vscode/src/view/common/Dropdown.tsx b/extensions/ql-vscode/src/view/common/Dropdown.tsx
index 494d9b1ab..a1a2889d0 100644
--- a/extensions/ql-vscode/src/view/common/Dropdown.tsx
+++ b/extensions/ql-vscode/src/view/common/Dropdown.tsx
@@ -20,7 +20,7 @@ type Props = {
   options: Array<{ value: string; label: string }>;
   disabled?: boolean;
   disabledPlaceholder?: string;
-  onChange: (event: ChangeEvent<HTMLSelectElement>) => void;
+  onChange?: (event: ChangeEvent<HTMLSelectElement>) => void;
 };
 
 /**
diff --git a/extensions/ql-vscode/src/view/model-editor/InProgressDropdown.tsx b/extensions/ql-vscode/src/view/model-editor/InProgressDropdown.tsx
index ecfa44e3d..03fb14edf 100644
--- a/extensions/ql-vscode/src/view/model-editor/InProgressDropdown.tsx
+++ b/extensions/ql-vscode/src/view/model-editor/InProgressDropdown.tsx
@@ -2,17 +2,12 @@ import * as React from "react";
 import { Dropdown } from "../common/Dropdown";
 
 export const InProgressDropdown = () => {
-  const noop = () => {
-    // Do nothing
-  };
-
   return (
     <Dropdown
       value="Thinking..."
       options={[]}
       disabled={true}
       disabledPlaceholder="Thinking..."
-      onChange={noop}
     />
   );
 };