From 8aec438307605177a017fcd918937c1fb791f854 Mon Sep 17 00:00:00 2001 From: Koen Vlaswinkel Date: Mon, 9 Sep 2024 10:58:46 +0200 Subject: [PATCH] Bump minimum VS Code version for warnings --- extensions/ql-vscode/src/extension.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/extensions/ql-vscode/src/extension.ts b/extensions/ql-vscode/src/extension.ts index 6a2a922c3..4f7c8cd99 100644 --- a/extensions/ql-vscode/src/extension.ts +++ b/extensions/ql-vscode/src/extension.ts @@ -300,12 +300,12 @@ const shouldUpdateOnNextActivationKey = "shouldUpdateOnNextActivation"; const codeQlVersionRange = DEFAULT_DISTRIBUTION_VERSION_RANGE; -// This is the minimum version of vscode that we _want_ to support. We want to update to Node 18, but that -// requires 1.82 or later. If we change the minimum version in the package.json, then anyone on an older version of vscode will +// This is the minimum version of vscode that we _want_ to support. We want to update to Node 20, but that +// requires 1.90 or later. If we change the minimum version in the package.json, then anyone on an older version of vscode will // silently be unable to upgrade. So, the solution is to first bump the minimum version here and release. Then // bump the version in the package.json and release again. This way, anyone on an older version of vscode will get a warning // before silently being refused to upgrade. -const MIN_VERSION = "1.82.0"; +const MIN_VERSION = "1.90.0"; function sendConfigTelemetryData() { const config: Record = {};