From e332b26f29980190b26db3828d85bc52d2f6748d Mon Sep 17 00:00:00 2001 From: Koen Vlaswinkel Date: Tue, 10 Oct 2023 15:51:59 +0200 Subject: [PATCH] Fix bug when selecting method without modeled methods When selecting a method that has no modeled methods, the modeling state would not contain an entry for the method signature. This would cause the `modeledMethods` to be `undefined`, which is not allowed according to its type. --- extensions/ql-vscode/src/model-editor/modeling-store.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/extensions/ql-vscode/src/model-editor/modeling-store.ts b/extensions/ql-vscode/src/model-editor/modeling-store.ts index aaa203658..6563d8b72 100644 --- a/extensions/ql-vscode/src/model-editor/modeling-store.ts +++ b/extensions/ql-vscode/src/model-editor/modeling-store.ts @@ -330,7 +330,7 @@ export class ModelingStore extends DisposableObject { databaseItem: dbItem, method, usage, - modeledMethods: dbState.modeledMethods[method.signature], + modeledMethods: dbState.modeledMethods[method.signature] ?? [], isModified: dbState.modifiedMethodSignatures.has(method.signature), }); } @@ -349,7 +349,7 @@ export class ModelingStore extends DisposableObject { return { method: selectedMethod, usage: dbState.selectedUsage, - modeledMethods: dbState.modeledMethods[selectedMethod.signature], + modeledMethods: dbState.modeledMethods[selectedMethod.signature] ?? [], isModified: dbState.modifiedMethodSignatures.has( selectedMethod.signature, ),