From e04f941cee63d96ccbce7f47b0ae2fb9016ef362 Mon Sep 17 00:00:00 2001
From: Koen Vlaswinkel <koesie10@github.com>
Date: Thu, 24 Nov 2022 10:44:08 +0100
Subject: [PATCH] Fix spy on undefined variable

---
 extensions/ql-vscode/package.json                  |  2 +-
 .../variant-analysis-manager.test.ts               | 14 +++++++++-----
 2 files changed, 10 insertions(+), 6 deletions(-)

diff --git a/extensions/ql-vscode/package.json b/extensions/ql-vscode/package.json
index 84183eecd..a80973645 100644
--- a/extensions/ql-vscode/package.json
+++ b/extensions/ql-vscode/package.json
@@ -1275,7 +1275,7 @@
     "integration": "npm-run-all integration:*",
     "integration:no-workspace": "jest --projects out/vscode-tests/no-workspace",
     "integration:minimal-workspace": "node ./out/vscode-tests/run-integration-tests.js minimal-workspace",
-    "cli-integration": "jest --config=out/vscode-tests/cli-integration/jest.config.js out/vscode-tests/cli-integration",
+    "cli-integration": "jest --projects out/vscode-tests/cli-integration",
     "update-vscode": "node ./node_modules/vscode/bin/install",
     "format": "prettier --write **/*.{ts,tsx} && eslint . --ext .ts,.tsx --fix",
     "lint": "eslint . --ext .ts,.tsx --max-warnings=0",
diff --git a/extensions/ql-vscode/src/vscode-tests/cli-integration/remote-queries/variant-analysis-manager.test.ts b/extensions/ql-vscode/src/vscode-tests/cli-integration/remote-queries/variant-analysis-manager.test.ts
index 997e3d331..3016b63d4 100644
--- a/extensions/ql-vscode/src/vscode-tests/cli-integration/remote-queries/variant-analysis-manager.test.ts
+++ b/extensions/ql-vscode/src/vscode-tests/cli-integration/remote-queries/variant-analysis-manager.test.ts
@@ -764,16 +764,20 @@ describe("Variant Analysis Manager", () => {
       });
 
       describe("removeVariantAnalysis", () => {
-        const removeAnalysisResultsStub = jest.spyOn(
-          variantAnalysisResultsManager,
-          "removeAnalysisResults",
-        );
+        let removeAnalysisResultsStub: jest.SpyInstance<
+          void,
+          [variantAnalysis: VariantAnalysisModule.VariantAnalysis]
+        >;
         const removeStorageStub = jest.spyOn(fs, "remove");
         let dummyVariantAnalysis: VariantAnalysis;
 
         beforeEach(async () => {
           dummyVariantAnalysis = createMockVariantAnalysis({});
-          removeAnalysisResultsStub.mockReturnValue(undefined);
+
+          removeAnalysisResultsStub = jest
+            .spyOn(variantAnalysisResultsManager, "removeAnalysisResults")
+            .mockReturnValue(undefined);
+
           removeStorageStub.mockReturnValue(undefined);
         });